From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EAFD2750E6 for ; Mon, 14 Apr 2025 15:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744645255; cv=none; b=bO7BiajyrbYP8FzwojuVZKavdGIJM8InNvEdEV5jrYZFZ/g3H6+h9Y1LTLsmihnzQce01wsBdsWFjhWU+80y+Qe1wZ7BdQXD9f5T3ZNYmyr/ivhY2tsS7x2I7b5lKJ0XTrStMyR8FlWwOupQqU+iz1nnKPi45RUJLTTILHH923M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744645255; c=relaxed/simple; bh=Y2R2YkgMI4z5Gdq/9hMDzIFoW0ch3l2+U7PzSeN3pOA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nL7AseY7cFYkBv7Ppb9llLYE/hY10tBYK3Epd3DewE4v1RAVm3Dj2kREfNupOQlDoOsnIpV0SjJA4cd7gXMXo8fi957RqasvZnDBJEWPvwyoSdhfM5bNY0IHV6m76TxiGupDpq5CB3eevWRbwwVUYxhL0z/ebA73eVqWzn+gnp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MHCc1usb; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MHCc1usb" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-47686580529so47798921cf.2 for ; Mon, 14 Apr 2025 08:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744645252; x=1745250052; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=THkCE1P6uezsB9SiyYtWzI3sCDAsq5Y3PC8P0mjg8FU=; b=MHCc1usbJwTUE08HePOnLCOk9yCJVwxBg5KUw4R+PnEp6yj7dhaS51/dCmqHyKt7at weoO8din9ARmwUkqLiI0Htaf+v8N2ZAK9Wu3Kx//gexqOjQHIOyBFfUoeNjywmbHlFAO cYqyHLqlQxBVsxyUgJkbegZnhvDpNfPr0ehVjfpTw8Rpa3Qr3+zlXIjbBX8cdanSf84K RCq6VSdZHQxLoqYGT9rWd2Xbal6VoSV/YYbsawonTc95nVsDOaetzPdHxMt2nZ2L4oJ6 9jZurE/gcOU/OXT64YsriWye6bIN8fy/kpQt52Qli6KYeLptUgmHFUHbFp3hJITrc+R3 +YDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744645252; x=1745250052; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=THkCE1P6uezsB9SiyYtWzI3sCDAsq5Y3PC8P0mjg8FU=; b=ZN2uP/nsgE/Ig5EeFCiRFVuKNkwllR/5AhBCLB7ojPysb1jaqGUqDVcNljUilYwGuS SPhku2Pu2sdOoxHhcnKPb90XP6r8hdXKYqUt6aRAjc6KkWddG2HkYmDbeIE/w/BZ0X5A GiDu0VZVN5l5wSfD8Pj4GTwoVIbNKZGm/9d0uPhVPZmZgzCGyv3G4hYdl+3NRFmFkz3D T3bRgmJNbbHL60sB0cJGdH+ChF3jD0dyxhiVt3SeIx5DS/Ol0GzAS8DlkELTCE0uX098 X/vG3lhFuzCb1+M3ObFj8eaWvuLqSZMXKW2Pes3pZ200zfa411lUuAQ5xLihJzDuPVRY 9VtQ== X-Forwarded-Encrypted: i=1; AJvYcCXNItQVIq6i07zmF5l+bQBn2dpvkJrbFwbpsa/Lzc39FxNxFQ7ldfH2yO+QVNYQR+5aIzjbUfzhY6pVRT9e@lists.linux.dev X-Gm-Message-State: AOJu0YwxIK35VEpY5heHuy9MSTtlA/v3KhhnLkX5GyaQfgVXIh+6LJIR y30nlbkzRXWYl6zZA8rqNMN+d//gvAAO7W8v7QDq5uo7finjLQNO X-Gm-Gg: ASbGncsNSe3ncAQmii/rG6gwo+sO5ZjJy7BzWKhe72zptKO4PRQ0oGopjJDIWlrCKKx hw0Q+v9QJWyluybAazzA6Yv39E72nE7qZiuy1rlZtB2fQjVZ5DeRktK89lU15VtZlcNAubYlwDq y+jlaSJ0nw7thilakr20ywDH6lqIeNO1BJnnk9jQ4SO+yCe/ybqBAtmYZCGdP0W7a39kBRex1un MoOne5n3udPiD7dHHcmC23NW+fA4Mn26bn7IKUejkbkaLC8cW0wNR0o6ZWQ1KiRRyIkcvNsL98k PW1OrDmNOb/0hWV6elS5WHucRSFfoU1SjOsHig49G8KXrAIvg16krxiEJzvbd1yjMYFnhIYBbCc iFZoIevCInol4CL40cw0= X-Google-Smtp-Source: AGHT+IEwo4m61h2lh7WsG10CzeSqTahaZOSmn4LaTbTF1zwgcXtuS8psu/bJtldb9rrV8Bhc4Bt7PA== X-Received: by 2002:ac8:7dcc:0:b0:477:8a94:dc77 with SMTP id d75a77b69052e-4797750f99amr136157491cf.9.1744645252140; Mon, 14 Apr 2025 08:40:52 -0700 (PDT) Received: from theriatric.mshome.net (c-73-123-232-110.hsd1.ma.comcast.net. [73.123.232.110]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4796eb2d020sm76433801cf.36.2025.04.14.08.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Apr 2025 08:40:51 -0700 (PDT) From: Gabriel Shahrouzi To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: gshahrouzi@gmail.com, skhan@linuxfoundation.org, kernelmentees@lists.linuxfoundation.org, stable@vger.kernel.org Subject: [PATCH v3] iio: adc: Correct conditional logic for store mode Date: Mon, 14 Apr 2025 11:40:49 -0400 Message-ID: <20250414154050.469482-1-gshahrouzi@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mode setting logic in ad7816_store_mode was reversed due to incorrect handling of the strcmp return value. strcmp returns 0 on match, so the `if (strcmp(buf, "full"))` block executed when the input was not "full". This resulted in "full" setting the mode to AD7816_PD (power-down) and other inputs setting it to AD7816_FULL. Fix this by checking it against 0 to correctly check for "full" and "power-down", mapping them to AD7816_FULL and AD7816_PD respectively. Fixes: 7924425db04a ("staging: iio: adc: new driver for AD7816 devices") Cc: stable@vger.kernel.org Signed-off-by: Gabriel Shahrouzi --- Changes since v3: - Tag stable@vger.kernel.org instead of an email CC - Use the correct version for patch Changes since v2: - Add fixes tag that references commit that introduced the bug. - Replace sysfs_streq with strcmp. --- drivers/staging/iio/adc/ad7816.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c index 6c14d7bcdd675..081b17f498638 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -136,7 +136,7 @@ static ssize_t ad7816_store_mode(struct device *dev, struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); - if (strcmp(buf, "full")) { + if (strcmp(buf, "full") == 0) { gpiod_set_value(chip->rdwr_pin, 1); chip->mode = AD7816_FULL; } else { -- 2.43.0