From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Rubin <matchstick@neverthere.org>
Cc: dpenkler@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] staging: gpib: Removing unused function CFGn
Date: Tue, 15 Apr 2025 16:47:34 +0200 [thread overview]
Message-ID: <2025041522-startling-parlor-aa65@gregkh> (raw)
In-Reply-To: <20250409181809.401724-1-matchstick@neverthere.org>
On Wed, Apr 09, 2025 at 06:18:09PM +0000, Michael Rubin wrote:
> Removing CFGn since it is not called by kernel code nor any of the gpib
> drivers.
>
> Signed-off-by: Michael Rubin <matchstick@neverthere.org>
> ---
> drivers/staging/gpib/uapi/gpib_user.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/gpib/uapi/gpib_user.h b/drivers/staging/gpib/uapi/gpib_user.h
> index eaf7399a164a..1cb6b6219e67 100644
> --- a/drivers/staging/gpib/uapi/gpib_user.h
> +++ b/drivers/staging/gpib/uapi/gpib_user.h
> @@ -192,11 +192,6 @@ static inline __u8 PPE_byte(unsigned int dio_line, int sense)
> return cmd;
> }
>
> -static inline __u8 CFGn(unsigned int meters)
> -{
> - return 0x6 | (meters & 0xf);
> -}
> -
> /* mask of bits that actually matter in a command byte */
> enum {
> gpib_command_mask = 0x7f,
> --
> 2.43.0
>
>
Already in my tree? I'm confused, this didn't apply at all.
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-15 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 18:18 [PATCH v1] staging: gpib: Removing unused function CFGn Michael Rubin
2025-04-15 14:47 ` Greg KH [this message]
2025-04-17 0:57 ` Michael Rubin
2025-04-17 9:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025041522-startling-parlor-aa65@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matchstick@neverthere.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox