From: Greg KH <gregkh@linuxfoundation.org>
To: "Paul Retourné" <paul.retourne@orange.fr>
Cc: dpenkler@gmail.com, dan.carpenter@linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: gpib: include: fixes multiline comments style
Date: Thu, 17 Apr 2025 11:23:50 +0200 [thread overview]
Message-ID: <2025041748-opposing-macaroni-8a89@gregkh> (raw)
In-Reply-To: <20250416210411.9300-2-paul.retourne@orange.fr>
On Wed, Apr 16, 2025 at 02:04:09PM -0700, Paul Retourné wrote:
> Fixes the style of multiline comments to comply with the linux kernel
> coding style.
>
> Signed-off-by: Paul Retourné <paul.retourne@orange.fr>
I've applied this (took some manual intervention on my side), but:
> @@ -37,11 +38,13 @@ struct gpib_board_config {
> unsigned int ibirq;
> /* dma channel to use for non-pnp cards (set by core, driver should make local copy) */
> unsigned int ibdma;
> - /* pci bus of card, useful for distinguishing multiple identical pci cards
> + /*
> + * pci bus of card, useful for distinguishing multiple identical pci cards
> * (negative means don't care)
> */
> int pci_bus;
For these, and the other definitions in this file, can you move the
comments to use the proper kerneldoc format for the structure, so that
the tools can properly document the structures in here? Having comments
above the variables really is not the best way to do this.
thanks,
greg k-h
prev parent reply other threads:[~2025-04-17 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 21:04 [PATCH v2] staging: gpib: include: fixes multiline comments style Paul Retourné
2025-04-17 9:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025041748-opposing-macaroni-8a89@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paul.retourne@orange.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox