From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andreas Kleinbichler <andi.kleinbichler@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [Patch]: staging: greybus: camera: fix alignment should match open parentheses
Date: Fri, 25 Apr 2025 13:51:48 +0200 [thread overview]
Message-ID: <2025042527-ligament-backlog-f512@gregkh> (raw)
In-Reply-To: <aApq_JPIBhnGqfiR@andreas-VirtualBox>
On Thu, Apr 24, 2025 at 06:46:52PM +0200, Andreas Kleinbichler wrote:
> Correct the alignment of the parameters to match the open parenthesis.
>
> Reported by checkpatch:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Andreas Kleinbichler <andi.kleinbichler@gmail.com>
> ---
> drivers/staging/greybus/camera.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index ec9fddfc0b14..a1b76df39a8f 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -263,9 +263,10 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> * Validate the stream configuration response verifying padding is correctly
> * set and the returned number of streams is supported
> */
> -static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
> - struct gb_camera_configure_streams_response *resp,
> - unsigned int nstreams)
> +static const int gb_camera_configure_streams_validate_response
> + (struct gb_camera *gcam,
But that's not right either :(
There is no real "fix" possible for this warning, sorry.
greg k-h
prev parent reply other threads:[~2025-04-25 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 16:46 [PATCH] [Patch]: staging: greybus: camera: fix alignment should match open parentheses Andreas Kleinbichler
2025-04-25 11:51 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042527-ligament-backlog-f512@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andi.kleinbichler@gmail.com \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox