Re: [PATCH] staging: rtl8723bs: Fix CamelCase and coding style issues across driver

Greg KH
2025-04-27T06:06:54Z

On Sun, Apr 27, 2025 at 01:20:01AM +0200, Ariel Simulevski wrote:
> This is a resend of the patch with the correct CC to linux-staging@lists.linux.dev.
> No changes to the patch itself.
>
> This patch renames several functions and variables from CamelCase
> to snake_case across the rtl8723bs driver, in accordance with the
> Linux kernel coding style guidelines.
>
> It also addresses various minor coding style warnings reported
> by checkpatch.pl, including line length violations, missing spaces,
> and other formatting cleanups.
>
> No functional changes were made.
>
> Signed-off-by: Ariel Simulevski <ariel@simulevski.at>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot