From: Greg KH <gregkh@linuxfoundation.org>
To: Erick Karanja <karanja99erick@gmail.com>
Cc: julia.lawall@inria.fr, philipp.g.hortmann@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Replace manual mutex handling with scoped_guard()
Date: Tue, 29 Apr 2025 14:25:25 +0200 [thread overview]
Message-ID: <2025042905-enunciate-sixfold-bd3f@gregkh> (raw)
In-Reply-To: <20250429120513.168674-1-karanja99erick@gmail.com>
On Tue, Apr 29, 2025 at 03:05:13PM +0300, Erick Karanja wrote:
> This refactor replaces manual mutex lock/unlock with scoped_guard()
> in places where early exits use goto. Using scoped_guard()
> avoids error-prone unlock paths and simplifies control flow.
Again, for new code, this is fine. But don't add it to old stuff unless
you really have a good reason to do so.
Unless you have the hardware and can test that your change was correct.
Do you have such hardware and was it tested?
thanks,
greg k-h
prev parent reply other threads:[~2025-04-29 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 12:05 [PATCH] staging: rtl8723bs: Replace manual mutex handling with scoped_guard() Erick Karanja
2025-04-29 12:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042905-enunciate-sixfold-bd3f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=karanja99erick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox