From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org, Dave Penkler <dpenkler@gmail.com>
Subject: [PATCH 3/3 V2] staging: gpib: Avoid unused variable warning
Date: Fri, 2 May 2025 09:21:50 +0200 [thread overview]
Message-ID: <20250502072150.32714-4-dpenkler@gmail.com> (raw)
In-Reply-To: <20250502072150.32714-1-dpenkler@gmail.com>
This addresses a warning produced by make W=1 with the configuration
parameter CONFIG_GPIB_PCMCIA=y
ines/ines_gpib.c:1115:28: warning: variable 'dev' set but not used [-Wunused-but-set-variable]
Remove the declaration and assignment of the unused variable.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
V1 -> V2
Remove the setting of the unused variable and say so in
the commit message
drivers/staging/gpib/ines/ines_gpib.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/ines/ines_gpib.c
index a16219c0f7c8..c851fd014f48 100644
--- a/drivers/staging/gpib/ines/ines_gpib.c
+++ b/drivers/staging/gpib/ines/ines_gpib.c
@@ -1112,12 +1112,9 @@ static int ines_gpib_config_iteration(struct pcmcia_device *link, void *priv_dat
*/
static int ines_gpib_config(struct pcmcia_device *link)
{
- struct local_info *dev;
int retval;
void __iomem *virt;
- dev = link->priv;
-
retval = pcmcia_loop_config(link, &ines_gpib_config_iteration, NULL);
if (retval) {
dev_warn(&link->dev, "no configuration found\n");
--
2.49.0
next prev parent reply other threads:[~2025-05-02 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 7:21 [PATCH 0/3 V2] staging: gpib: ines driver fix and cleanup Dave Penkler
2025-05-02 7:21 ` [PATCH 1/3 V2] staging: gpib: Fix PCMCIA config identifier Dave Penkler
2025-05-02 7:21 ` [PATCH 2/3 V2] staging: gpib: Declare driver entry points static Dave Penkler
2025-05-02 7:21 ` Dave Penkler [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-27 9:19 [PATCH 3/3 V2] staging: gpib: Avoid unused variable warning Dave Penkler
2025-04-28 5:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502072150.32714-4-dpenkler@gmail.com \
--to=dpenkler@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox