From: Hans de Goede <hdegoede@redhat.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [PATCH 3/5] media: atomisp: Stop pipeline on atomisp_css_start() failure
Date: Mon, 5 May 2025 23:00:06 +0200 [thread overview]
Message-ID: <20250505210008.152659-4-hdegoede@redhat.com> (raw)
In-Reply-To: <20250505210008.152659-1-hdegoede@redhat.com>
atomisp_start_streaming() starts the media pipeline before calling
atomisp_css_start(). On atomisp_css_start() failures stop the pipeline
before returning the error.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
index 491af67cc7a8..fecba2588e38 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
@@ -982,6 +982,7 @@ int atomisp_start_streaming(struct vb2_queue *vq, unsigned int count)
ret = atomisp_css_start(asd);
if (ret) {
atomisp_flush_video_pipe(pipe, VB2_BUF_STATE_QUEUED, true);
+ media_pipeline_stop(&asd->video_out.vdev.entity.pads[0]);
goto out_unlock;
}
--
2.49.0
next prev parent reply other threads:[~2025-05-05 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 21:00 [PATCH 0/5] media: atomisp: stream start/stop error handling improvements Hans de Goede
2025-05-05 21:00 ` [PATCH 1/5] media: atomisp: Move atomisp_stop_streaming() above atomisp_start_streaming() Hans de Goede
2025-05-05 21:00 ` [PATCH 2/5] media: atomisp: Properly stop the ISP stream on sensor streamon errors Hans de Goede
2025-05-05 21:00 ` Hans de Goede [this message]
2025-05-05 21:00 ` [PATCH 4/5] media: atomisp: Always free MIPI / CSI-receiver buffers from ia_css_uninit() Hans de Goede
2025-05-05 21:00 ` [PATCH 5/5] media: atomisp: Fix "stop stream timeout." error Hans de Goede
2025-05-07 6:18 ` [PATCH 0/5] media: atomisp: stream start/stop error handling improvements Andy Shevchenko
2025-07-04 9:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505210008.152659-4-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox