Re: [PATCH 6/6] media: atomisp: Switch to int3472 driver sensor GPIO mapping code

Ilpo Järvinen
2025-05-08T14:09:32Z

[-- Attachment #1: Type: text/plain, Size: 2494 bytes --]

On Thu, 8 May 2025, Hans de Goede wrote:

> Hi,
>
> On 8-May-25 3:56 PM, Hans de Goede wrote:
> > Hi,
> >
> > On 8-May-25 3:48 PM, Ilpo Järvinen wrote:
> >> On Thu, 8 May 2025, Hans de Goede wrote:
> >>> On 8-May-25 10:34 AM, Andy Shevchenko wrote:
> >>>> On Wed, May 7, 2025 at 9:48 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >>>>>
> >>>>> Replace the duplicate code for calling the special Intel camera sensor GPIO
> >>>>> type _DSM (79234640-9e10-4fea-a5c1-b5aa8b19756f) and mapping GPIOs to
> >>>>> the sensor with a call to int3472_discrete_parse_crs() from the int3472
> >>>>> driver.
> >>>>>
> >>>>> Besides avoiding code duplication the int3472 version of the code also
> >>>>> supports more features, like mapping the powerdown GPIO to a regulator on
> >>>>> the mt9m114 which is necessary to make the camera on the Asus T100TA work.
> >>>>
> >>>> ...
> >>>>
> >>>> Don't you need the Kconfig(s) update to have proper dependencies all
> >>>> over these cases?
> >>>
> >>> Yes I do, I thought about doing this already but forgot to actually
> >>> do it, thank you for catching this.
> >>>
> >>> When I've some time for it I'll prepare a v2 of just this patch
> >>> addressing this and your s/then/than/ remark.
> >>>
> >>> Since you and Sakari are happy with them patches 1-5 can be picked up
> >>> and merged by Ilpo as is, so I do not plan to send a v2 of those.
> >>
> >> Thanks for the quick reviews.
> >>
> >> I took patch 1-5 into the review-ilpo-next branch with one typo in
> >> change log fixed (reser -> reset).
> >
> > Great, thank you!
>
> Ilpo, I just noticed that Sakari typod his Reviewed-by, it reads:
>
> Reviwed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> and this is also how the tag looks in review-ilpo-next now.
> so missing an 'e' you probably will want to fix this.
>
> Also Sakari gave an Acked-by for patch 6/6, but since he did so
> in a reply to the cover letter all 5 (1-5) patches now have:
>
> Reviwed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> so besides adding the missing 'e' you probably will also want
> to drop the entire Acked-by.

Yeah, a perfect example of tunnel vision. I was looking specifically
whether those reviewed-bys got added by b4 into all patches but failed to
notice any of those errors despite staring at the very lines. Thanks for
letting me know, I'll fix them.

--
i.