Re: [PATCH 6/6] media: atomisp: Switch to int3472 driver sensor GPIO mapping code

Hans de Goede
2025-07-04T09:37:19Z

Hi,

On 8-May-25 10:34 AM, Andy Shevchenko wrote:
> On Wed, May 7, 2025 at 9:48 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Replace the duplicate code for calling the special Intel camera sensor GPIO
>> type _DSM (79234640-9e10-4fea-a5c1-b5aa8b19756f) and mapping GPIOs to
>> the sensor with a call to int3472_discrete_parse_crs() from the int3472
>> driver.
>>
>> Besides avoiding code duplication the int3472 version of the code also
>> supports more features, like mapping the powerdown GPIO to a regulator on
>> the mt9m114 which is necessary to make the camera on the Asus T100TA work.
>
> ...
>
> Don't you need the Kconfig(s) update to have proper dependencies all
> over these cases?

A good point, not sure what you mean with "all over these cases" since
this just affects the main atomisp module. But yes the Kconfig deps
of the main atomisp module needs to be updated, I've added the following
while merging this:

depends on INTEL_SKL_INT3472

> Otherwise I am fully in favour of this change and the series as a whole, thanks!
>
> ...
>
>> + /*
>> + * On atomisp the _DSM to get the GPIO type must be made on the sensor
>> + * adev, rather then on a separate INT3472 adev.
>
> rather than

Thank you, I've also fixed this while merging this into
my media-atomisp branch:

https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans