Re: [PATCH 6/6] media: atomisp: Switch to int3472 driver sensor GPIO mapping code

Ilpo Järvinen
2025-05-08T13:48:38Z

[-- Attachment #1: Type: text/plain, Size: 2013 bytes --]

On Thu, 8 May 2025, Hans de Goede wrote:
> On 8-May-25 10:34 AM, Andy Shevchenko wrote:
> > On Wed, May 7, 2025 at 9:48 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >>
> >> Replace the duplicate code for calling the special Intel camera sensor GPIO
> >> type _DSM (79234640-9e10-4fea-a5c1-b5aa8b19756f) and mapping GPIOs to
> >> the sensor with a call to int3472_discrete_parse_crs() from the int3472
> >> driver.
> >>
> >> Besides avoiding code duplication the int3472 version of the code also
> >> supports more features, like mapping the powerdown GPIO to a regulator on
> >> the mt9m114 which is necessary to make the camera on the Asus T100TA work.
> >
> > ...
> >
> > Don't you need the Kconfig(s) update to have proper dependencies all
> > over these cases?
>
> Yes I do, I thought about doing this already but forgot to actually
> do it, thank you for catching this.
>
> When I've some time for it I'll prepare a v2 of just this patch
> addressing this and your s/then/than/ remark.
>
> Since you and Sakari are happy with them patches 1-5 can be picked up
> and merged by Ilpo as is, so I do not plan to send a v2 of those.

Thanks for the quick reviews.

I took patch 1-5 into the review-ilpo-next branch with one typo in
change log fixed (reser -> reset).

> > Otherwise I am fully in favour of this change and the series as a whole, thanks!
> >
> > ...
> >
> >> + /*
> >> + * On atomisp the _DSM to get the GPIO type must be made on the sensor
> >> + * adev, rather then on a separate INT3472 adev.
> >
> > rather than
> >
> > (FWIW, it's your typical mistake, it's something like the 10th time I
> > noticed it :-)
>
> Yeah, I'll try to remember to double check for this spelling mistake
> myself, but I'm afraid I'll probably never learn. We have something
> somewhat similar to than vs then in Dutch and I even do it wrong there :)

I know the feeling, muscle memory is extremely hard to override. :-)

--
i.