Re: [PATCH 0/6] platform/x86: int3472: Allow re-using sensor GPIO mapping in atomisp

Andy Shevchenko
2025-05-08T08:38:10Z

On Thu, May 8, 2025 at 11:36 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, May 7, 2025 at 9:52 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> > This patch series does some small refactoring of the int3472 code to allow
> > re-using the sensor GPIO mapping code in the atomisp driver and then the
> > final patch in the series moves the atomisp driver over.
> >
> > About merging this, maybe the int3472 patches can be merged in time for
> > the 6.16 merge window and then the atomisp patch can be merged after
> > 6.16-rc1 is released, otherwise an immutable pdx86 branch with the first
> > 5 patches will be necessary.
>
> Overall I'm pretty much liking this series, but one comment against
> the last patch (see there) and one question here. Can you isolate GPIO
> mapping code in a separate file, please? This will help to generalise
> this code outside of two mentioned drivers (I might need it in the
> future for something else, not related to cameras at all).

Ah, and formal
Reviewed-by: Andy Shevchenko <andy@kernel.org>
for patches 1-5.

--
With Best Regards,
Andy Shevchenko