public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Thomas Andreatta <thomasandreatta2000@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dpenkler@gmail.com, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] Staging: common: gpib_os: simplify return value handling
Date: Sat, 10 May 2025 19:43:30 +0200	[thread overview]
Message-ID: <20250510174330.297207-1-thomas.andreatta2000@gmail.com> (raw)
In-Reply-To: <2025051046-ipad-overdrawn-8890@gregkh>

> But again, as this can not fail, why is this needed?

Agree, should've checked it before trying to solve the "FIXME".

> Start way back at the "ends" of the call chain.  If they can fail, then
start propagating the error up all the way to here.

Sounds logic, will add it to my check-list from now on, thanks!

Best,
Thomas

  reply	other threads:[~2025-05-10 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-10 15:37 [PATCH 1/2] Staging: common: iblib: Changed ibrsc function type Thomas Andreatta
2025-05-10 15:38 ` [PATCH 2/2] Staging: common: gpib_os: `request_system_control_ioctl` return value Thomas Andreatta
2025-05-10 16:45   ` Greg KH
2025-05-10 17:43     ` Thomas Andreatta [this message]
2025-05-10 16:44 ` [PATCH 1/2] Staging: common: iblib: Changed ibrsc function type Greg KH
2025-05-12 14:48 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250510174330.297207-1-thomas.andreatta2000@gmail.com \
    --to=thomasandreatta2000@gmail.com \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox