Re: [rft, PATCH v2 0/3] media: atomisp: replace math macros

Hans de Goede
2025-07-06T16:11:32Z

Hi,

On 19-May-25 5:46 PM, Andy Shevchenko wrote:
> Kill unused definitions that may use custom macros from math_support.h
> and reduce usage of the latter and even kill some of them at the end
> of the series.
>
> Please, apply only after tests that confirm everything is working
> as expected.
>
> Changelog v2:
> - added a cleanup patch 1
> - removed potential div-by-0 conversions

Thanks, patch looks good to me and this time things don't crash
during testing:

Reviewed-by: Hans de Goede <hansg@kernel.org>
Tested-by: Hans de Goede <hansg@kernel.org>

I have merged the series in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this series will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans

> v1:
> https://lore.kernel.org/linux-media/20240923085652.3457117-1-andriy.shevchenko@linux.intel.com/
>
> Andy Shevchenko (3):
> media: atomisp: Remove unused header
> media: atomisp: Replace macros from math_support.h
> media: atomisp: Remove no more used macros from math_support.h
>
> .../pci/hive_isp_css_include/math_support.h | 5 -
> .../kernels/anr/anr_1.0/ia_css_anr_types.h | 4 +-
> .../pci/isp/kernels/dpc2/ia_css_dpc2_param.h | 6 +-
> .../isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c | 4 +-
> .../isp/kernels/eed1_8/ia_css_eed1_8_param.h | 22 +--
> .../isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c | 6 +-
> .../isp/kernels/sc/sc_1.0/ia_css_sc_param.h | 2 +-
> .../pci/isp/modes/interface/input_buf.isp.h | 6 +-
> .../pci/isp/modes/interface/isp_const.h | 157 ------------------
> .../pci/runtime/debug/src/ia_css_debug.c | 1 -
> .../atomisp/pci/runtime/frame/src/frame.c | 29 ++--
> .../atomisp/pci/runtime/ifmtr/src/ifmtr.c | 11 +-
> .../pci/runtime/isys/src/virtual_isys.c | 2 +-
> .../staging/media/atomisp/pci/sh_css_defs.h | 12 +-
> .../media/atomisp/pci/sh_css_internal.h | 8 +-
> .../media/atomisp/pci/sh_css_param_dvs.h | 22 +--
> .../staging/media/atomisp/pci/sh_css_params.c | 12 +-
> 17 files changed, 77 insertions(+), 232 deletions(-)
> delete mode 100644 drivers/staging/media/atomisp/pci/isp/modes/interface/isp_const.h
>