Re: [PATCH 1/2] staging: sm750fb: rename dprBase to dpr_base

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, May 18, 2025 at 03:09:46PM -0700, Eric Florin wrote:
> Rename `dprBase` to `dpr_base` to conform with kernel style guidelines
> as reported by checkpatch.pl
> 
> CHECK: Avoid CamelCase: <dprBase>
> 
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
>  drivers/staging/sm750fb/sm750.h       | 2 +-
>  drivers/staging/sm750fb/sm750_accel.c | 4 ++--
>  drivers/staging/sm750fb/sm750_hw.c    | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index aff69661c8e6..a2342c69a65a 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -50,7 +50,7 @@ struct init_status {
>  
>  struct lynx_accel {
>  	/* base virtual address of DPR registers */
> -	volatile unsigned char __iomem *dprBase;
> +	volatile unsigned char __iomem *dpr_base;

Are you sure this isn't coming directly from a hardware data sheet or
description somewhere?  Based on the type, it really looks like it is.
If not, please document it properly that you have researched this in the
changelog text when resending.

Don't change variable names that reflect external names, that just makes
for more confusion over time.

thanks,

greg k-h