From: Donny Turizo <donnyturizo13@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Donny Turizo <donnyturizo13@gmail.com>
Subject: [PATCH v4] staging: rtl8723bs: Fix camelCase to snake_case style in core files
Date: Sun, 25 May 2025 06:44:25 +0000 [thread overview]
Message-ID: <20250525064426.9662-1-donnyturizo13@gmail.com> (raw)
This patch renames functions _Read_Macreg and _Write_Macreg to
_read_macreg and _write_macreg respectively, aligning them with the
Linux kernel naming convention of using snake_case for identifiers.
These Changes improve code readability and maintain consistency with
the kernel coding style, particulary in the rtl8723bs staging driver.
No functional changes introduced.
Signed-off-by: Donny Turizo <donnyturizo13@gmail.com>
---
v2: Corrected the base branch used for the patch.
v3: Rebased onto a branch not maintained by Greg Kroah-Hartmant.
Also updated the commit message body, changed the "From" field to my
real name, and updated the Signed-off-by line accordingly.
v4: Rebased properly onto Greg Kroah-Hartman staging tree to ensure
correct upstream submission.
In v2, the patch was rebased onto the correct tree, but in v3 it was
rebased onto a branch not maintained by Greg Kroah-Hartman by mistake
This version fixes that by ensuring the patch is based properly on
GREGKH staging tree, required for upstream acceptance.
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 437934dd255e..49bcefb5e8d2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -9,8 +9,8 @@
#include <linux/jiffies.h>
static struct _cmd_callback rtw_cmd_callback[] = {
- {GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
- {GEN_CMD_CODE(_Write_MACREG), NULL},
+ {GEN_CMD_CODE(_read_macreg), NULL}, /*0*/
+ {GEN_CMD_CODE(_write_macreg), NULL},
{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
{GEN_CMD_CODE(_Write_BBREG), NULL},
{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
--
2.43.0
next reply other threads:[~2025-05-25 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 6:44 Donny Turizo [this message]
2025-06-04 11:00 ` [PATCH v4] staging: rtl8723bs: Fix camelCase to snake_case style in core files kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250525064426.9662-1-donnyturizo13@gmail.com \
--to=donnyturizo13@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox