From: clingfei <clf700383@gmail.com>
To: elder@kernel.org
Cc: johan@kernel.org, vireshk@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, clf700383@gmail.com
Subject: [PATCH] greybus: Avoid fake flexible array for response data
Date: Mon, 26 May 2025 19:06:54 +0800 [thread overview]
Message-ID: <20250526110654.3916536-1-clf700383@gmail.com> (raw)
As https://lore.kernel.org/all/20240304211940.it.083-kees@kernel.org/
pointed out, to enforce the 0-sized destinations, the remaining 0-sized
destinations need to be handled. Thus the struct
gb_control_get_manifest_response and struct gb_i2c_transfer_response
are removed.
Signed-off-by: clingfei <clf700383@gmail.com>
---
drivers/staging/greybus/i2c.c | 9 ++++-----
include/linux/greybus/greybus_protocols.h | 9 ---------
2 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c
index 14f1ff6d448c..2857c2834206 100644
--- a/drivers/staging/greybus/i2c.c
+++ b/drivers/staging/greybus/i2c.c
@@ -144,15 +144,14 @@ gb_i2c_operation_create(struct gb_connection *connection,
}
static void gb_i2c_decode_response(struct i2c_msg *msgs, u32 msg_count,
- struct gb_i2c_transfer_response *response)
+ u8 *data)
{
struct i2c_msg *msg = msgs;
- u8 *data;
u32 i;
- if (!response)
+ if (!data)
return;
- data = response->data;
+
for (i = 0; i < msg_count; i++) {
if (msg->flags & I2C_M_RD) {
memcpy(msg->buf, data, msg->len);
@@ -188,7 +187,7 @@ static int gb_i2c_transfer_operation(struct gb_i2c_device *gb_i2c_dev,
ret = gb_operation_request_send_sync(operation);
if (!ret) {
- struct gb_i2c_transfer_response *response;
+ u8 *response;
response = operation->response->payload;
gb_i2c_decode_response(msgs, msg_count, response);
diff --git a/include/linux/greybus/greybus_protocols.h b/include/linux/greybus/greybus_protocols.h
index 820134b0105c..14395f9300d6 100644
--- a/include/linux/greybus/greybus_protocols.h
+++ b/include/linux/greybus/greybus_protocols.h
@@ -110,11 +110,6 @@ struct gb_control_get_manifest_size_response {
__le16 size;
} __packed;
-/* Control protocol manifest get request has no payload */
-struct gb_control_get_manifest_response {
- __u8 data[0];
-} __packed;
-
/* Control protocol [dis]connected request */
struct gb_control_connected_request {
__le16 cport_id;
@@ -678,10 +673,6 @@ struct gb_i2c_transfer_request {
__le16 op_count;
struct gb_i2c_transfer_op ops[]; /* op_count of these */
} __packed;
-struct gb_i2c_transfer_response {
- __u8 data[0]; /* inbound data */
-} __packed;
-
/* GPIO */
--
2.34.1
next reply other threads:[~2025-05-26 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 11:06 clingfei [this message]
2025-05-26 11:37 ` [PATCH] greybus: Avoid fake flexible array for response data Dan Carpenter
2025-05-27 3:36 ` Kees Cook
2025-05-26 12:21 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-02-16 23:28 Kees Cook
2024-02-17 20:17 ` Alex Elder
2024-02-17 21:58 ` Kees Cook
2024-02-18 16:48 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526110654.3916536-1-clf700383@gmail.com \
--to=clf700383@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox