From: Nam Cao <namcao@linutronix.de>
To: Donny Turizo <donnyturizo13@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] staging: rtl8723bs: rename _Read_EEPROM and other functions to snake_case
Date: Wed, 28 May 2025 23:15:33 +0200 [thread overview]
Message-ID: <20250528211533.DIM_zxnE@linutronix.de> (raw)
In-Reply-To: <20250527004327.3627-1-donnyturizo13@gmail.com>
On Tue, May 27, 2025 at 12:43:27AM +0000, Donny Turizo wrote:
> Renamed _Read_EEPROM and several other functions in rtw_cmd.c to follow
> the kernel coding style (snake_case). This fixes checkpatch warnings
> related to naming conventions.
>
> Signed-off-by: Donny Turizo <donnyturizo13@gmail.com>
>
> ---
> v8:
> Actually rebased on top of the latest gregkh/staging-testing.
> In v7 I mentioned a rebase, but I had forgotten to run
> `git fetch gregkh`, so the patch was not properly rebased.
> No code changes from v7. Only the base of the patch is updated.
I still cannot apply the patch. Are you sure you rebased correctly? You
mentioned that the patch didn't change, so I think no :(
I couldn't apply it to verify the build, but I seriously doubt that this
patch doesn't break the build. Are you sure you built the driver? Make sure
you have CONFIG_RTL8723BS=y in your .config file. Also double check that
there is a drivers/staging/rtl8723bs/core/rtw_cmd.o object file after the
build.
Best regards,
Nam
next prev parent reply other threads:[~2025-05-28 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 0:43 [PATCH v8] staging: rtl8723bs: rename _Read_EEPROM and other functions to snake_case Donny Turizo
2025-05-28 21:15 ` Nam Cao [this message]
2025-05-28 21:31 ` Nam Cao
2025-06-02 6:00 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528211533.DIM_zxnE@linutronix.de \
--to=namcao@linutronix.de \
--cc=donnyturizo13@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox