From: kernel test robot <lkp@intel.com>
To: Donny Turizo <donnyturizo13@gmail.com>, gregkh@linuxfoundation.org
Cc: oe-kbuild-all@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Donny Turizo <donnyturizo13@gmail.com>
Subject: Re: [PATCH v3] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms'
Date: Thu, 5 Jun 2025 00:16:25 +0800 [thread overview]
Message-ID: <202506050029.f8Llelhe-lkp@intel.com> (raw)
In-Reply-To: <20250522211626.4931-1-donnyturizo13@gmail.com>
Hi Donny,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Donny-Turizo/staging-rtl8723bs-Fix-typo-in-variable-name-ips_deffer_ms/20250523-052530
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250522211626.4931-1-donnyturizo13%40gmail.com
patch subject: [PATCH v3] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms'
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20250605/202506050029.f8Llelhe-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250605/202506050029.f8Llelhe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506050029.f8Llelhe-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c: In function '_rtw_pwr_wakeup':
>> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:1076:48: error: 'ips_deffer_ms' undeclared (first use in this function); did you mean 'ips_defer_ms'?
1076 | deny_time = jiffies + msecs_to_jiffies(ips_deffer_ms);
| ^~~~~~~~~~~~~
| ips_defer_ms
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:1076:48: note: each undeclared identifier is reported only once for each function it appears in
vim +1076 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
554c0a3abf216c Hans de Goede 2017-03-29 1012
3a0e883f688e25 Donny Turizo 2025-05-22 1013 int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_defer_ms, const char *caller)
554c0a3abf216c Hans de Goede 2017-03-29 1014 {
554c0a3abf216c Hans de Goede 2017-03-29 1015 struct dvobj_priv *dvobj = adapter_to_dvobj(padapter);
554c0a3abf216c Hans de Goede 2017-03-29 1016 struct pwrctrl_priv *pwrpriv = dvobj_to_pwrctl(dvobj);
554c0a3abf216c Hans de Goede 2017-03-29 1017 struct mlme_priv *pmlmepriv;
554c0a3abf216c Hans de Goede 2017-03-29 1018 int ret = _SUCCESS;
554c0a3abf216c Hans de Goede 2017-03-29 1019 unsigned long start = jiffies;
3a0e883f688e25 Donny Turizo 2025-05-22 1020 unsigned long deny_time = jiffies + msecs_to_jiffies(ips_defer_ms);
554c0a3abf216c Hans de Goede 2017-03-29 1021
554c0a3abf216c Hans de Goede 2017-03-29 1022 /* for LPS */
554c0a3abf216c Hans de Goede 2017-03-29 1023 LeaveAllPowerSaveMode(padapter);
554c0a3abf216c Hans de Goede 2017-03-29 1024
554c0a3abf216c Hans de Goede 2017-03-29 1025 /* IPS still bound with primary adapter */
554c0a3abf216c Hans de Goede 2017-03-29 1026 padapter = GET_PRIMARY_ADAPTER(padapter);
554c0a3abf216c Hans de Goede 2017-03-29 1027 pmlmepriv = &padapter->mlmepriv;
554c0a3abf216c Hans de Goede 2017-03-29 1028
554c0a3abf216c Hans de Goede 2017-03-29 1029 if (time_before(pwrpriv->ips_deny_time, deny_time))
554c0a3abf216c Hans de Goede 2017-03-29 1030 pwrpriv->ips_deny_time = deny_time;
554c0a3abf216c Hans de Goede 2017-03-29 1031
554c0a3abf216c Hans de Goede 2017-03-29 1032
709c8e49b51c37 Fabio Aiuto 2021-04-07 1033 if (pwrpriv->ps_processing)
554c0a3abf216c Hans de Goede 2017-03-29 1034 while (pwrpriv->ps_processing && jiffies_to_msecs(jiffies - start) <= 3000)
8204b61a775879 Jia-Ju Bai 2018-09-15 1035 mdelay(10);
554c0a3abf216c Hans de Goede 2017-03-29 1036
709c8e49b51c37 Fabio Aiuto 2021-04-07 1037 if (!(pwrpriv->bInternalAutoSuspend) && pwrpriv->bInSuspend)
8ec06b9ff8a4f5 Ross Schmidt 2020-11-09 1038 while (pwrpriv->bInSuspend && jiffies_to_msecs(jiffies - start) <= 3000
709c8e49b51c37 Fabio Aiuto 2021-04-07 1039 )
8204b61a775879 Jia-Ju Bai 2018-09-15 1040 mdelay(10);
554c0a3abf216c Hans de Goede 2017-03-29 1041
554c0a3abf216c Hans de Goede 2017-03-29 1042 /* System suspend is not allowed to wakeup */
2e20a5ac67f8a5 Nishka Dasgupta 2019-07-25 1043 if (!(pwrpriv->bInternalAutoSuspend) && pwrpriv->bInSuspend) {
554c0a3abf216c Hans de Goede 2017-03-29 1044 ret = _FAIL;
554c0a3abf216c Hans de Goede 2017-03-29 1045 goto exit;
554c0a3abf216c Hans de Goede 2017-03-29 1046 }
554c0a3abf216c Hans de Goede 2017-03-29 1047
554c0a3abf216c Hans de Goede 2017-03-29 1048 /* block??? */
2e20a5ac67f8a5 Nishka Dasgupta 2019-07-25 1049 if (pwrpriv->bInternalAutoSuspend && padapter->net_closed) {
554c0a3abf216c Hans de Goede 2017-03-29 1050 ret = _FAIL;
554c0a3abf216c Hans de Goede 2017-03-29 1051 goto exit;
554c0a3abf216c Hans de Goede 2017-03-29 1052 }
554c0a3abf216c Hans de Goede 2017-03-29 1053
554c0a3abf216c Hans de Goede 2017-03-29 1054 /* I think this should be check in IPS, LPS, autosuspend functions... */
2e20a5ac67f8a5 Nishka Dasgupta 2019-07-25 1055 if (check_fwstate(pmlmepriv, _FW_LINKED)) {
554c0a3abf216c Hans de Goede 2017-03-29 1056 ret = _SUCCESS;
554c0a3abf216c Hans de Goede 2017-03-29 1057 goto exit;
554c0a3abf216c Hans de Goede 2017-03-29 1058 }
554c0a3abf216c Hans de Goede 2017-03-29 1059
554c0a3abf216c Hans de Goede 2017-03-29 1060 if (rf_off == pwrpriv->rf_pwrstate) {
554c0a3abf216c Hans de Goede 2017-03-29 1061 {
bc21df678b4d5d Zhansaya Bagdauletkyzy 2021-04-06 1062 if (ips_leave(padapter) == _FAIL) {
554c0a3abf216c Hans de Goede 2017-03-29 1063 ret = _FAIL;
554c0a3abf216c Hans de Goede 2017-03-29 1064 goto exit;
554c0a3abf216c Hans de Goede 2017-03-29 1065 }
554c0a3abf216c Hans de Goede 2017-03-29 1066 }
554c0a3abf216c Hans de Goede 2017-03-29 1067 }
554c0a3abf216c Hans de Goede 2017-03-29 1068
554c0a3abf216c Hans de Goede 2017-03-29 1069 /* TODO: the following checking need to be merged... */
8ec06b9ff8a4f5 Ross Schmidt 2020-11-09 1070 if (padapter->bDriverStopped || !padapter->bup || !padapter->hw_init_completed) {
554c0a3abf216c Hans de Goede 2017-03-29 1071 ret = false;
554c0a3abf216c Hans de Goede 2017-03-29 1072 goto exit;
554c0a3abf216c Hans de Goede 2017-03-29 1073 }
554c0a3abf216c Hans de Goede 2017-03-29 1074
554c0a3abf216c Hans de Goede 2017-03-29 1075 exit:
554c0a3abf216c Hans de Goede 2017-03-29 @1076 deny_time = jiffies + msecs_to_jiffies(ips_deffer_ms);
554c0a3abf216c Hans de Goede 2017-03-29 1077 if (time_before(pwrpriv->ips_deny_time, deny_time))
554c0a3abf216c Hans de Goede 2017-03-29 1078 pwrpriv->ips_deny_time = deny_time;
554c0a3abf216c Hans de Goede 2017-03-29 1079 return ret;
554c0a3abf216c Hans de Goede 2017-03-29 1080
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-06-04 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 21:16 [PATCH v3] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms' Donny Turizo
2025-06-04 16:16 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506050029.f8Llelhe-lkp@intel.com \
--to=lkp@intel.com \
--cc=donnyturizo13@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox