From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Florin <ericflorin@google.com>
Cc: teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] staging: sm750fb: rename `Bpp` parameter
Date: Thu, 19 Jun 2025 17:30:13 +0200 [thread overview]
Message-ID: <2025061949-estrogen-progeny-5553@gregkh> (raw)
In-Reply-To: <5f9c28d0dc0f48151837f11d5f6e7b82f84978ef.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:27AM -0700, Eric Florin wrote:
> Rename `Bpp` to `bpp` in `sm750_hw_copyarea` to conform with kernel
> style guidelines.
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index ea64e10d4814..a34d8f6a033d 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
> * @sy: Starting y coordinate of source surface
> * @d_base: Address of destination: offset in frame buffer
> * @d_pitch: Pitch value of destination surface in BYTE
> - * @Bpp: Color depth of destination surface
> + * @bpp: Color depth of destination surface
What does "bpp" mean here? How about "dest_depth"?
next prev parent reply other threads:[~2025-06-19 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 17:11 [PATCH 0/6] staging: sm750fb: cleanup `sm750_hw_copyarea` Eric Florin
2025-05-27 17:11 ` [PATCH 1/6] staging: sm750fb: rename `sBase` parameter Eric Florin
2025-06-19 15:29 ` Greg KH
2025-05-27 17:11 ` [PATCH 2/6] staging: sm750fb: rename `sPitch` parameter Eric Florin
2025-06-19 15:29 ` Greg KH
2025-05-27 17:11 ` [PATCH 3/6] staging: sm750fb: rename `dBase` parameter Eric Florin
2025-06-19 15:30 ` Greg KH
2025-05-27 17:11 ` [PATCH 4/6] staging: sm750fb: rename `dPitch` parameter Eric Florin
2025-06-19 15:29 ` Greg KH
2025-05-27 17:11 ` [PATCH 5/6] staging: sm750fb: rename `Bpp` parameter Eric Florin
2025-06-19 15:30 ` Greg KH [this message]
2025-05-27 17:11 ` [PATCH 6/6] staging: sm750fb: Rename local var `nDirection` Eric Florin
2025-06-19 15:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025061949-estrogen-progeny-5553@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ericflorin@google.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox