From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Abdalla Al-Dalleh <abdalla.ahmad@sesame.org.jo>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Gabriel Shahrouzi" <gshahrouzi@gmail.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>
Subject: Re: [PATCH] drivers: staging: iio: frequency: ad9832.h: Fixed TODO note.
Date: Sat, 28 Jun 2025 07:08:46 +0100 [thread overview]
Message-ID: <2025062815-resolute-cornflake-48c4@gregkh> (raw)
In-Reply-To: <20250627175114.548076-1-abdalla.ahmad@sesame.org.jo>
On Fri, Jun 27, 2025 at 08:51:14PM +0300, Abdalla Al-Dalleh wrote:
> - drivers/staging/iio/frequency/ad9832.c: Changed .h file location
> - drivers/staging/iio/frequency/ad9832.h: Removed struct definition
> - include/linux/iio/dac/ad9832.h: Added header file according to the
> TODO note.
>
> Signed-off-by: Abdalla Al-Dalleh <abdalla.ahmad@sesame.org.jo>
> ---
> drivers/staging/iio/frequency/ad9832.c | 3 +--
> drivers/staging/iio/frequency/ad9832.h | 23 ------------------
> include/linux/iio/dac/ad9832.h | 33 ++++++++++++++++++++++++++
Staging drivers need to be "self-contained" for now.
Why do you even need a .h file for a single .c file anyway? Why not
just remove it?
thanks,
greg k-h
next prev parent reply other threads:[~2025-06-28 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 17:51 [PATCH] drivers: staging: iio: frequency: ad9832.h: Fixed TODO note Abdalla Al-Dalleh
2025-06-27 18:35 ` Andy Shevchenko
2025-06-27 19:29 ` Abdalla Ahmad
2025-06-27 19:45 ` Dan Carpenter
2025-06-27 20:32 ` David Lechner
2025-06-28 15:12 ` Jonathan Cameron
2025-06-28 6:08 ` Greg Kroah-Hartman [this message]
2025-06-28 15:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025062815-resolute-cornflake-48c4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=abdalla.ahmad@sesame.org.jo \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gshahrouzi@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox