From: "Ignacio Peña" <ignacio.pena87@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Cc: Ignacio Pena <ignacio.pena87@gmail.com>
Subject: [PATCH 1/4] staging: rtl8723bs: fix yoda condition in rtl8723b_cmd
Date: Wed, 16 Jul 2025 07:38:05 -0400 [thread overview]
Message-ID: <20250716113808.73115-1-ignacio.pena87@gmail.com> (raw)
From: Ignacio Pena <ignacio.pena87@gmail.com>
Fix checkpatch warning about comparisons that should place the
constant on the right side of the test.
Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
index 56526056d..abc123def 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
@@ -24,7 +24,7 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num)
do {
valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);
- if (0 == valid) {
+ if (valid == 0) {
read_down = true;
}
} while ((!read_down) && (retry_cnts--));
--
2.39.5
next reply other threads:[~2025-07-16 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 11:38 Ignacio Peña [this message]
2025-07-16 11:38 ` [PATCH 2/4] staging: rtl8723bs: remove unnecessary braces in rtl8723b_cmd Ignacio Peña
2025-07-16 11:38 ` [PATCH 3/4] staging: rtl8723bs: fix block comment alignment " Ignacio Peña
2025-07-16 12:01 ` Greg KH
2025-07-16 14:58 ` Dan Carpenter
2025-07-16 11:38 ` [PATCH 4/4] staging: rtl8723bs: fix tab spacing " Ignacio Peña
2025-07-16 12:01 ` Greg KH
2025-07-16 14:57 ` [PATCH 1/4] staging: rtl8723bs: fix yoda condition " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716113808.73115-1-ignacio.pena87@gmail.com \
--to=ignacio.pena87@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).