From: Greg KH <gregkh@linuxfoundation.org>
To: "Ignacio Peña" <ignacio.pena87@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH 4/4] staging: rtl8723bs: fix tab spacing in rtl8723b_cmd
Date: Wed, 16 Jul 2025 14:01:39 +0200 [thread overview]
Message-ID: <2025071628-bunion-skedaddle-dded@gregkh> (raw)
In-Reply-To: <20250716113808.73115-4-ignacio.pena87@gmail.com>
On Wed, Jul 16, 2025 at 07:38:08AM -0400, Ignacio Peña wrote:
> From: Ignacio Pena <ignacio.pena87@gmail.com>
>
> Fix checkpatch warning about space before tab in commented code.
>
> Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index 789abc123..012def345 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -77,7 +77,7 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd
> else {
> memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3);
> memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3);
> -/* *(u8 *)(&h2c_cmd) |= BIT(7); */
> +/* *(u8 *)(&h2c_cmd) |= BIT(7); */
Why is this line even still needed?
next prev parent reply other threads:[~2025-07-16 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 11:38 [PATCH 1/4] staging: rtl8723bs: fix yoda condition in rtl8723b_cmd Ignacio Peña
2025-07-16 11:38 ` [PATCH 2/4] staging: rtl8723bs: remove unnecessary braces " Ignacio Peña
2025-07-16 11:38 ` [PATCH 3/4] staging: rtl8723bs: fix block comment alignment " Ignacio Peña
2025-07-16 12:01 ` Greg KH
2025-07-16 14:58 ` Dan Carpenter
2025-07-16 11:38 ` [PATCH 4/4] staging: rtl8723bs: fix tab spacing " Ignacio Peña
2025-07-16 12:01 ` Greg KH [this message]
2025-07-16 14:57 ` [PATCH 1/4] staging: rtl8723bs: fix yoda condition " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071628-bunion-skedaddle-dded@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).