Re: [PATCH] staging: rtl8723bs: Fix multiple checkpatch warnings in rtl8723b_cmd.c

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Jul 16, 2025 at 12:12:36AM -0400, Ignacio Peña wrote:
> Fix the following checkpatch warnings:
> - Comparisons should place the constant on the right side
> - Braces {} are not necessary for single statement blocks
> - Block comments should align the * on each line
> - No space before tabs
> 
> These are coding style fixes that improve code readability.
> 
> Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 40 ++++++++++----------
>  1 file changed, 19 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index 56526056d..4f33f4f0c 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -24,9 +24,8 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num)
>  
>  	do {
>  		valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);
> -		if (0 == valid) {
> +		if (valid == 0)
>  			read_down = true;
> -		}
>  	} while ((!read_down) && (retry_cnts--));
>  
>  	return read_down;
> @@ -35,13 +34,13 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num)
>  
>  
>  /*****************************************
> -* H2C Msg format :
> -*| 31 - 8		|7-5	| 4 - 0	|
> -*| h2c_msg	|Class	|CMD_ID	|
> -*| 31-0						|
> -*| Ext msg					|
> -*
> -******************************************/
> + * H2C Msg format :
> + * | 31 - 8		|7-5	| 4 - 0	|
> + * | h2c_msg	|Class	|CMD_ID	|
> + * | 31-0						|
> + * | Ext msg					|
> + *
> + ******************************************/
>  s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer)
>  {
>  	u8 h2c_box_num;
> @@ -57,13 +56,11 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd
>  	if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->h2c_fwcmd_mutex)))
>  		return ret;
>  
> -	if (!pCmdBuffer) {
> +	if (!pCmdBuffer)
>  		goto exit;
> -	}
>  
> -	if (CmdLen > RTL8723B_MAX_CMD_LEN) {
> +	if (CmdLen > RTL8723B_MAX_CMD_LEN)
>  		goto exit;
> -	}
>  
>  	if (padapter->bSurpriseRemoved)
>  		goto exit;
> @@ -80,7 +77,7 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd
>  		else {
>  			memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3);
>  			memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3);
> -/* 			*(u8 *)(&h2c_cmd) |= BIT(7); */
> +/* *(u8 *)(&h2c_cmd) |= BIT(7); */
>  		}
>  
>  		*(u8 *)(&h2c_cmd) |= ElementID;
> @@ -438,13 +435,14 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapter, u8 psmode)
>  
>  		}
>  
> -/* offload to FW if fw version > v15.10
> -		pmlmeext->DrvBcnEarly = 0;
> -		pmlmeext->DrvBcnTimeOut =7;
> -
> -		if ((pmlmeext->DrvBcnEarly!= 0Xff) && (pmlmeext->DrvBcnTimeOut!= 0xff))
> -			u1H2CPwrModeParm[H2C_PWRMODE_LEN-1] = BIT(0) | ((pmlmeext->DrvBcnEarly<<1)&0x0E) |((pmlmeext->DrvBcnTimeOut<<4)&0xf0) ;
> -*/
> +/*
> + * offload to FW if fw version > v15.10
> + *		pmlmeext->DrvBcnEarly = 0;
> + *		pmlmeext->DrvBcnTimeOut =7;
> + *
> + *		if ((pmlmeext->DrvBcnEarly!= 0Xff) && (pmlmeext->DrvBcnTimeOut!= 0xff))
> + *			u1H2CPwrModeParm[H2C_PWRMODE_LEN-1] = BIT(0) | ((pmlmeext->DrvBcnEarly<<1)&0x0E) |((pmlmeext->DrvBcnTimeOut<<4)&0xf0) ;
> + */
>  
>  	}
>  
> -- 
> 2.39.5 (Apple Git-154)
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot