From: Greg KH <gregkh@linuxfoundation.org>
To: "Ignacio Peña" <ignacio.pena87@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/3] staging: rtl8723bs: remove unnecessary comment separator lines
Date: Wed, 16 Jul 2025 14:00:06 +0200 [thread overview]
Message-ID: <2025071645-portly-battalion-a295@gregkh> (raw)
In-Reply-To: <20250716113740.73025-1-ignacio.pena87@gmail.com>
On Wed, Jul 16, 2025 at 07:37:38AM -0400, Ignacio Peña wrote:
> From: Ignacio Pena <ignacio.pena87@gmail.com>
>
> Remove the long dashed separator lines from block comments as they
> don't follow kernel coding style, as suggested by Greg KH.
>
> Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 7a74b011d..abc123def 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -70,7 +70,6 @@ Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)
> * When Who Remark
> * 11/17/2008 MHC Create Version 0.
> *
> - *---------------------------------------------------------------------------*/
> void
> Efuse_PowerSwitch(
> struct adapter *padapter,
> @@ -163,7 +162,6 @@ EFUSE_GetEfuseDefinition(
> * When Who Remark
> * 09/23/2008 MHC Copy from WMAC.
> *
> - *---------------------------------------------------------------------------*/
> u8
> EFUSE_Read1Byte(
> struct adapter *Adapter,
> @@ -313,7 +311,6 @@ Efuse_WordEnableDataWrite(struct adapter *padapter,
> * When Who Remark
> * 11/11/2008 MHC Create Version 0.
> *
> - *---------------------------------------------------------------------------*/
> void
> Efuse_ReadAllMap(
> struct adapter *padapter,
> @@ -350,7 +347,6 @@ void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse, bool bP
> * When Who Remark
> * 11/12/2008 MHC Create Version 0.
> *
> - *---------------------------------------------------------------------------*/
> static void efuse_ShadowRead1Byte(struct adapter *padapter, u16 Offset, u8 *Value)
> {
> struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
> @@ -396,7 +392,6 @@ static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Val
> * When Who Remark
> * 11/13/2008 MHC Create Version 0.
> *
> - *---------------------------------------------------------------------------*/
> void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoTest)
> {
> struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
> @@ -429,7 +424,6 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoT
> * When Who Remark
> * 11/12/2008 MHC Create Version 0.
> *
> - *---------------------------------------------------------------------------*/
> void EFUSE_ShadowRead(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value)
> {
> if (Type == 1)
> --
> 2.39.5
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2025-07-16 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 11:37 [PATCH v2 1/3] staging: rtl8723bs: remove unnecessary comment separator lines Ignacio Peña
2025-07-16 11:37 ` [PATCH v2 2/3] staging: rtl8723bs: add missing blank line after declaration Ignacio Peña
2025-07-16 12:00 ` Greg KH
2025-07-16 11:37 ` [PATCH v2 3/3] staging: rtl8723bs: remove unnecessary commented code Ignacio Peña
2025-07-16 12:00 ` Greg KH
2025-07-16 12:00 ` Greg KH [this message]
2025-07-16 14:49 ` [PATCH v2 1/3] staging: rtl8723bs: remove unnecessary comment separator lines Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071645-portly-battalion-a295@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox