From: Greg KH <gregkh@linuxfoundation.org>
To: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Improve indentation consistency in rtw_mlme.c
Date: Sun, 20 Jul 2025 08:42:27 +0200 [thread overview]
Message-ID: <2025072044-program-certified-8112@gregkh> (raw)
In-Reply-To: <20250719230707.238377-1-vivek.balachandhar@gmail.com>
On Sat, Jul 19, 2025 at 11:07:07PM +0000, Vivek BalachandharTN wrote:
> This patch cleans up inconsistent indentation in rtw_mlme.c to improve code
> readability and align with kernel coding style.
Ok, but:
> @@ -119,7 +123,7 @@ struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv)
> pnetwork = NULL;
> goto exit;
> }
> - plist = get_next(&(free_queue->queue));
> + plist = get_next(&free_queue->queue);
That is not an indentation issue.
> @@ -141,7 +145,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwor
> {
> unsigned int delta_time;
> u32 lifetime = SCANQUEUE_LIFETIME;
> - struct __queue *free_queue = &(pmlmepriv->free_bss_pool);
> + struct __queue *free_queue = &pmlmepriv->free_bss_pool;
Nor was that.
I stopped reviewing here, sorry.
Please only do one type of thing per patch.
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-20 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 23:07 [PATCH] staging: rtl8723bs: Improve indentation consistency in rtw_mlme.c Vivek BalachandharTN
2025-07-20 6:42 ` Greg KH [this message]
2025-07-20 8:44 ` [PATCH] staging: rtl8723bs: Improve indentation consistency in rtw_mlme.c — follow-up on patch strategy Vivek BalachandharTN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072044-program-certified-8112@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=vivek.balachandhar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).