Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ali Nasrolahi <a.nasrolahi01@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 2/3] staging: rtl8723bs: fix comment formatting in basic_types.h
Date: Mon, 21 Jul 2025 07:54:43 +0200	[thread overview]
Message-ID: <2025072133-aspirin-backlash-2084@gregkh> (raw)
In-Reply-To: <20250720145524.9733-3-A.Nasrolahi01@gmail.com>

On Sun, Jul 20, 2025 at 06:25:23PM +0330, Ali Nasrolahi wrote:
> Fix coding style issues reported by checkpatch.pl:
> - Adjusted block comment trailing markers
> - Unified comment spacing and indentation

These two are fine, but:

> - Removed redundant semicolon from macro definition

This needs to be a separate patch.

Again, each patch needs to do only one "logical" thing.  And that
logical thing can not be "fix a bunch of coding style issues that are of
different types", sorry.

Please fix up for this patch, and the 3/3 patch and submit an updated
series.

thanks,

greg k-h

  reply	other threads:[~2025-07-21  5:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-20 14:55 [PATCH v2 0/3] staging: rtl8723bs: fix coding style issues and improve readability Ali Nasrolahi
2025-07-20 14:55 ` [PATCH v2 1/3] staging: rtl8723bs: fix comment style and formatting in osdep_service.c Ali Nasrolahi
2025-07-20 14:55 ` [PATCH v2 2/3] staging: rtl8723bs: fix comment formatting in basic_types.h Ali Nasrolahi
2025-07-21  5:54   ` Greg KH [this message]
2025-07-20 14:55 ` [PATCH v2 3/3] staging: rtl8723bs: replace unnamed parameters in hal_btcoex.h for consistency Ali Nasrolahi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025072133-aspirin-backlash-2084@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.nasrolahi01@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox