Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bruce Qin <bqn9090@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: rtl8723bs: fix if-statement alignment and line continuation in rtw_ap.c
Date: Fri, 25 Jul 2025 06:40:59 +0200	[thread overview]
Message-ID: <2025072552-filled-glacier-1e9d@gregkh> (raw)
In-Reply-To: <20250724193037.23910-1-bqn9090@gmail.com>

On Thu, Jul 24, 2025 at 09:30:37PM +0200, Bruce Qin wrote:
> This patch fixes several style issues in a multiline if-statement:
> 
> - Moved '&&' to the end of the previous line to follow logical continuation style
> - Fixed indentation to align with the opening parenthesis of the expression
> - Avoided ending a line with an open parenthesis '('
> - Moved closing ')' to the end of the last expression line (as suggested by the maintainer)
> 
> These changes improve readability and conform to Linux kernel coding conventions.
> No functional changes.

Please wrap your changelog text at 72 columns, like checkpatch asks you
to.

> 
> Signed-off-by: Bruce Qin <bqn9090@gmail.com>
> ---
> Changes in v2:
> - Moved closing ')' to the previous line as suggested by Greg Kroah-Hartman.
> - Thanks for the review and feedback!

You sent 3 copies of this "v2" patch, how do I know which one is
correct?

Please fix up and send a v3.

thanks,

greg k-h

  reply	other threads:[~2025-07-25  4:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-20 17:34 [PATCH] staging: rtl8723bs: fix if-statement alignment and line continuation in rtw_ap.c Bruce Qin
2025-07-24  9:29 ` Greg KH
2025-07-24 17:17   ` Bruce Qin
2025-07-24 17:17     ` [PATCH v2] staging: rtl8723bs: fix if-statement alignment and line continuation in rtw_ap.c Bruce Qin
2025-07-24 18:38       ` Greg KH
2025-07-24 19:23   ` Bruce Qin
2025-07-24 19:25   ` Bruce Qin
2025-07-24 19:30   ` Bruce Qin
2025-07-25  4:40     ` Greg KH [this message]
2025-07-25 17:19       ` [PATCH v3] " Bruce Qin
2025-07-25 17:45         ` [PATCH v4] " Bruce Qin
2025-07-25 18:02           ` [PATCH v5] " Bruce Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025072552-filled-glacier-1e9d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bqn9090@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox