* [PATCH v11 1/4] staging: media: atomisp: improve kernel-doc for ia_css_aa_config
2025-07-26 7:53 [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory LiangCheng Wang
@ 2025-07-26 7:53 ` LiangCheng Wang
2025-07-26 7:53 ` [PATCH v11 2/4] staging: media: atomisp: fix indentation in anr files LiangCheng Wang
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: LiangCheng Wang @ 2025-07-26 7:53 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: linux-media, linux-kernel, linux-staging, llvm, LiangCheng Wang
Move kernel-doc comment for strength field in
ia_css_aa_config from inline to structure-level comment
for better readability and tooling compatibility.
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
.../media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
index 2f568a7062da726397f55b1e73dadd27fcd1f2f8..f825f537a5366f6b97170dd44827436fd800d105 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
@@ -28,11 +28,13 @@
* ISP block: BAA2
* ISP1: BAA2 is used.
* ISP2: BAA2 is used.
+ *
+ * @strength: Strength of the filter, in u0.13 fixed-point format.
+ * Valid range: [0, 8191]. A value of 0 means the filter is
+ * ineffective (default).
*/
struct ia_css_aa_config {
- u16 strength; /** Strength of the filter.
- u0.13, [0,8191],
- default/ineffective 0 */
+ u16 strength;
};
#endif /* __IA_CSS_AA2_TYPES_H */
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v11 2/4] staging: media: atomisp: fix indentation in anr files
2025-07-26 7:53 [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory LiangCheng Wang
2025-07-26 7:53 ` [PATCH v11 1/4] staging: media: atomisp: improve kernel-doc for ia_css_aa_config LiangCheng Wang
@ 2025-07-26 7:53 ` LiangCheng Wang
2025-07-26 7:53 ` [PATCH v11 3/4] staging: media: atomisp: use designated initializer in anr config LiangCheng Wang
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: LiangCheng Wang @ 2025-07-26 7:53 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: linux-media, linux-kernel, linux-staging, llvm, LiangCheng Wang
Fix inconsistent tab/space usage and bring function definitions
into a single-line format, matching kernel coding style.
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
.../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 20 +++++++-------------
.../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h | 20 +++++++-------------
.../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c | 14 +++++---------
.../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h | 13 +++++--------
4 files changed, 24 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
index 899d566234b9d3a35401666dcf0c7b1b80fd5b31..49c22a68ec552ed163e3268db2b823fc4ea73b36 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
@@ -21,20 +21,16 @@ const struct ia_css_anr_config default_anr_config = {
{10, 20, 30}
};
-void
-ia_css_anr_encode(
- struct sh_css_isp_anr_params *to,
- const struct ia_css_anr_config *from,
- unsigned int size)
+void ia_css_anr_encode(struct sh_css_isp_anr_params *to,
+ const struct ia_css_anr_config *from,
+ unsigned int size)
{
(void)size;
to->threshold = from->threshold;
}
-void
-ia_css_anr_dump(
- const struct sh_css_isp_anr_params *anr,
- unsigned int level)
+void ia_css_anr_dump(const struct sh_css_isp_anr_params *anr,
+ unsigned int level)
{
if (!anr) return;
ia_css_debug_dtrace(level, "Advance Noise Reduction:\n");
@@ -42,10 +38,8 @@ ia_css_anr_dump(
"anr_threshold", anr->threshold);
}
-void
-ia_css_anr_debug_dtrace(
- const struct ia_css_anr_config *config,
- unsigned int level)
+void ia_css_anr_debug_dtrace(const struct ia_css_anr_config *config,
+ unsigned int level)
{
ia_css_debug_dtrace(level,
"config.threshold=%d\n",
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h
index 4f77900871c8b9d43bdc00308aa914eda3af7fa7..2f17d62b92087afd26aff2a49dadf4ee2fb7fcf5 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h
@@ -12,20 +12,14 @@
extern const struct ia_css_anr_config default_anr_config;
-void
-ia_css_anr_encode(
- struct sh_css_isp_anr_params *to,
- const struct ia_css_anr_config *from,
- unsigned int size);
+void ia_css_anr_encode(struct sh_css_isp_anr_params *to,
+ const struct ia_css_anr_config *from,
+ unsigned int size);
-void
-ia_css_anr_dump(
- const struct sh_css_isp_anr_params *anr,
- unsigned int level);
+void ia_css_anr_dump(const struct sh_css_isp_anr_params *anr,
+ unsigned int level);
-void
-ia_css_anr_debug_dtrace(
- const struct ia_css_anr_config *config, unsigned int level)
-;
+void ia_css_anr_debug_dtrace(const struct ia_css_anr_config *config,
+ unsigned int level);
#endif /* __IA_CSS_ANR_HOST_H */
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c
index 09599884bdaefe32f891f437274b96110888a675..3c6d99139cda6f12eb6ef6fe8f996f7ff11551c2 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c
@@ -10,11 +10,9 @@
#include "ia_css_anr2.host.h"
-void
-ia_css_anr2_vmem_encode(
- struct ia_css_isp_anr2_params *to,
- const struct ia_css_anr_thres *from,
- size_t size)
+void ia_css_anr2_vmem_encode(struct ia_css_isp_anr2_params *to,
+ const struct ia_css_anr_thres *from,
+ size_t size)
{
unsigned int i;
@@ -28,10 +26,8 @@ ia_css_anr2_vmem_encode(
}
}
-void
-ia_css_anr2_debug_dtrace(
- const struct ia_css_anr_thres *config,
- unsigned int level)
+void ia_css_anr2_debug_dtrace(const struct ia_css_anr_thres *config,
+ unsigned int level)
{
(void)config;
(void)level;
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h
index 2b1105f21c1e2b37144083b6bb8f9dd465a2f43b..36fb6c25969991ffcdd4424a695dacc5b5c2a9db 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h
@@ -13,15 +13,12 @@
#include "ia_css_anr2_param.h"
#include "ia_css_anr2_table.host.h"
-void
-ia_css_anr2_vmem_encode(
- struct ia_css_isp_anr2_params *to,
- const struct ia_css_anr_thres *from,
- size_t size);
+void ia_css_anr2_vmem_encode(struct ia_css_isp_anr2_params *to,
+ const struct ia_css_anr_thres *from,
+ size_t size);
-void
-ia_css_anr2_debug_dtrace(
- const struct ia_css_anr_thres *config, unsigned int level)
+void ia_css_anr2_debug_dtrace(const struct ia_css_anr_thres *config,
+ unsigned int level)
;
#endif /* __IA_CSS_ANR2_HOST_H */
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v11 3/4] staging: media: atomisp: use designated initializer in anr config
2025-07-26 7:53 [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory LiangCheng Wang
2025-07-26 7:53 ` [PATCH v11 1/4] staging: media: atomisp: improve kernel-doc for ia_css_aa_config LiangCheng Wang
2025-07-26 7:53 ` [PATCH v11 2/4] staging: media: atomisp: fix indentation in anr files LiangCheng Wang
@ 2025-07-26 7:53 ` LiangCheng Wang
2025-07-26 7:53 ` [PATCH v11 4/4] staging: media: atomisp: fix indentation in bh host files LiangCheng Wang
2025-08-05 21:38 ` [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: LiangCheng Wang @ 2025-07-26 7:53 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: linux-media, linux-kernel, linux-staging, llvm, LiangCheng Wang
Improve readability by using designated initializer for
default_anr_config.
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
.../media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
index 49c22a68ec552ed163e3268db2b823fc4ea73b36..f4dd3ca03d75c32a0ac3798af031c6a3423a73fc 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
@@ -11,14 +11,14 @@
#include "ia_css_anr.host.h"
const struct ia_css_anr_config default_anr_config = {
- 10,
- {
+ .threshold = 10,
+ .thresholds = {
0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4
},
- {10, 20, 30}
+ .factors = {10, 20, 30},
};
void ia_css_anr_encode(struct sh_css_isp_anr_params *to,
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v11 4/4] staging: media: atomisp: fix indentation in bh host files
2025-07-26 7:53 [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory LiangCheng Wang
` (2 preceding siblings ...)
2025-07-26 7:53 ` [PATCH v11 3/4] staging: media: atomisp: use designated initializer in anr config LiangCheng Wang
@ 2025-07-26 7:53 ` LiangCheng Wang
2025-08-05 21:38 ` [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: LiangCheng Wang @ 2025-07-26 7:53 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: linux-media, linux-kernel, linux-staging, llvm, LiangCheng Wang
Fix inconsistent tab/space usage and bring function definitions
into a single-line format, matching kernel coding style.
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
.../media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c | 14 +++++---------
.../media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h | 14 +++++---------
2 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
index 69c87e53f3c22fade6c4c7914d1550f68dd8f5c2..b87eb1a21b216dc6132331d2a48d7cb56ddaea24 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
@@ -12,10 +12,8 @@
#include "ia_css_bh.host.h"
-void
-ia_css_bh_hmem_decode(
- struct ia_css_3a_rgby_output *out_ptr,
- const struct ia_css_bh_table *hmem_buf)
+void ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
+ const struct ia_css_bh_table *hmem_buf)
{
int i;
@@ -37,11 +35,9 @@ ia_css_bh_hmem_decode(
}
}
-void
-ia_css_bh_encode(
- struct sh_css_isp_bh_params *to,
- const struct ia_css_3a_config *from,
- unsigned int size)
+void ia_css_bh_encode(struct sh_css_isp_bh_params *to,
+ const struct ia_css_3a_config *from,
+ unsigned int size)
{
(void)size;
/* coefficients to calculate Y */
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
index 36b360cfe62e65037522e0037cf51fca0fabdfba..964d658ceec31b0b22fc3bc6d19b40b07b2fc06c 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
@@ -10,15 +10,11 @@
#include "ia_css_bh_param.h"
#include "s3a/s3a_1.0/ia_css_s3a_types.h"
-void
-ia_css_bh_hmem_decode(
- struct ia_css_3a_rgby_output *out_ptr,
- const struct ia_css_bh_table *hmem_buf);
+void ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
+ const struct ia_css_bh_table *hmem_buf);
-void
-ia_css_bh_encode(
- struct sh_css_isp_bh_params *to,
- const struct ia_css_3a_config *from,
- unsigned int size);
+void ia_css_bh_encode(struct sh_css_isp_bh_params *to,
+ const struct ia_css_3a_config *from,
+ unsigned int size);
#endif /* __IA_CSS_BH_HOST_H */
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory
2025-07-26 7:53 [PATCH v11 0/4] staging: media: atomisp: indentation cleanup per directory LiangCheng Wang
` (3 preceding siblings ...)
2025-07-26 7:53 ` [PATCH v11 4/4] staging: media: atomisp: fix indentation in bh host files LiangCheng Wang
@ 2025-08-05 21:38 ` Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-08-05 21:38 UTC (permalink / raw)
To: LiangCheng Wang
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, linux-media,
linux-kernel, linux-staging, llvm
On Sat, Jul 26, 2025 at 03:53:10PM +0800, LiangCheng Wang wrote:
> This patch focuses on cleaning up indentation (spaces, tabs) in the
> AtomISP driver under drivers/staging/media/atomisp/pci/isp/kernels/.
>
> There are no functional changes.
>
> This version splits the original cleanup patch into four smaller patches,
> following review feedback from Dan Carpenter to keep changes focused and easier to review.
This version LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread