From: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
vivek.balachandhar@gmail.com
Subject: [PATCH 02/20] staging: rtl8723bs: remove unnecessary blank lines around braces
Date: Sat, 26 Jul 2025 04:32:00 +0000 [thread overview]
Message-ID: <20250726043218.386738-3-vivek.balachandhar@gmail.com> (raw)
In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com>
The driver contained several unnecessary blank lines immediately
before or after opening and closing braces in function
definitions and control blocks.
These blank lines break the visual flow of the code and violate
the Linux kernel coding style, which discourages superfluous
vertical spacing.
This commit removes the extra blank lines to improve code
consistency and readability. No functional changes are introduced.
Identified using checkpatch.pl.
Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 29 -----------------------
1 file changed, 29 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index da64d5714237..24e505111f1f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -170,7 +170,6 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwor
void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork)
{
-
struct __queue *free_queue = &pmlmepriv->free_bss_pool;
if (!pnetwork)
@@ -225,11 +224,9 @@ void rtw_free_network_queue(struct adapter *padapter, u8 isfreeall)
phead = get_list_head(scanned_queue);
list_for_each_safe(plist, tmp, phead) {
-
pnetwork = list_entry(plist, struct wlan_network, list);
_rtw_free_network(pmlmepriv, pnetwork, isfreeall);
-
}
spin_unlock_bh(&scanned_queue->lock);
@@ -318,7 +315,6 @@ int rtw_is_same_ibss(struct adapter *adapter, struct wlan_network *pnetwork)
ret = true;
return ret;
-
}
inline int is_same_ess(struct wlan_bssid_ex *a, struct wlan_bssid_ex *b)
@@ -348,7 +344,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
(d_cap & WLAN_CAPABILITY_IBSS)) &&
((s_cap & WLAN_CAPABILITY_ESS) ==
(d_cap & WLAN_CAPABILITY_ESS));
-
}
struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, struct wlan_network *network)
@@ -380,7 +375,6 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct __queue *scanned_queue)
phead = get_list_head(scanned_queue);
list_for_each(plist, phead) {
-
pwlan = list_entry(plist, struct wlan_network, list);
if (!pwlan->fixed) {
@@ -389,7 +383,6 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct __queue *scanned_queue)
}
}
return oldest;
-
}
void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src,
@@ -424,7 +417,6 @@ void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src,
sq_final = dst->phy_info.signal_quality;
rssi_final = dst->rssi;
}
-
}
if (update_ie) {
@@ -486,7 +478,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned))
oldest = pnetwork;
-
}
/* If we didn't find a match, then get a new network slot to initialize
@@ -530,7 +521,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
pnetwork->network.phy_info.signal_quality = 0;
list_add_tail(&pnetwork->list, &queue->queue);
-
}
} else {
/* we have an entry and we are going to update it. But this entry may
@@ -591,7 +581,6 @@ int rtw_is_desired_network(struct adapter *adapter, struct wlan_network *pnetwor
return true;
else
return false;
-
}
if (adapter->registrypriv.wifi_spec == 1) { /* for correct flow of 8021X to do.... */
u8 *p = NULL;
@@ -868,7 +857,6 @@ void rtw_indicate_connect(struct adapter *padapter)
pmlmepriv->to_join = false;
if (!check_fwstate(&padapter->mlmepriv, _FW_LINKED)) {
-
set_fwstate(pmlmepriv, _FW_LINKED);
rtw_os_indicate_connect(padapter);
@@ -876,7 +864,6 @@ void rtw_indicate_connect(struct adapter *padapter)
rtw_set_to_roam(padapter, 0);
rtw_set_scan_deny(padapter, 3000);
-
}
/*
@@ -929,7 +916,6 @@ void rtw_scan_abort(struct adapter *adapter)
pmlmeext->scan_abort = true;
while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)
&& jiffies_to_msecs(start) <= 200) {
-
if (adapter->bDriverStopped || adapter->bSurpriseRemoved)
break;
@@ -1022,7 +1008,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, str
}
return psta;
-
}
/* pnetwork : returns from rtw_joinbss_event_callback */
@@ -1397,7 +1382,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) ||
check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) {
-
rtw_free_stainfo(adapter, psta);
if (adapter->stapriv.asoc_sta_count == 1) {/* a sta + bc/mc_stainfo (not Ibss_stainfo) */
@@ -1431,7 +1415,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
if (ret != _SUCCESS)
goto unlock;
}
-
}
unlock:
@@ -1490,7 +1473,6 @@ void _rtw_join_timeout_handler(struct timer_list *t)
/* indicate disconnect for the case that join_timeout and check_fwstate != FW_LINKED */
rtw_cfg80211_indicate_disconnect(adapter);
-
}
spin_unlock_bh(&pmlmepriv->lock);
@@ -1540,7 +1522,6 @@ static void rtw_auto_scan_handler(struct adapter *padapter)
if (pmlmepriv->auto_scan_int_ms != 0
&& jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->auto_scan_int_ms) {
-
if (!padapter->registrypriv.wifi_spec) {
if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) == true)
goto exit;
@@ -1673,12 +1654,10 @@ int rtw_select_roaming_candidate(struct mlme_priv *mlme)
phead = get_list_head(queue);
list_for_each(mlme->pscanned, phead) {
-
pnetwork = list_entry(mlme->pscanned, struct wlan_network,
list);
rtw_check_roaming_candidate(mlme, &candidate, pnetwork);
-
}
if (!candidate) {
@@ -1770,14 +1749,11 @@ int rtw_select_and_join_from_scanned_queue(struct mlme_priv *pmlmepriv)
phead = get_list_head(queue);
list_for_each(pmlmepriv->pscanned, phead) {
-
pnetwork = list_entry(pmlmepriv->pscanned,
struct wlan_network, list);
rtw_check_join_candidate(pmlmepriv, &candidate, pnetwork);
-
}
-
if (!candidate) {
ret = _FAIL;
goto exit;
@@ -1863,7 +1839,6 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp
adapter->securitypriv.key_mask |= BIT(psetkeyparm->keyid);
switch (psetkeyparm->algorithm) {
-
case _WEP40_:
keylen = 5;
memcpy(&psetkeyparm->key[0], &psecuritypriv->dot11DefKey[keyid].skey[0], keylen);
@@ -1939,7 +1914,6 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_
}
return ielength;
-
}
/* */
@@ -2311,7 +2285,6 @@ unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8 *out_
}
return phtpriv->ht_option;
-
}
/* the function is > passive_level (in critical_section) */
@@ -2346,7 +2319,6 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe
max_ampdu_sz = 1 << (max_ampdu_sz + 3); /* max_ampdu_sz (kbytes); */
phtpriv->rx_ampdu_maxlen = max_ampdu_sz;
-
}
len = 0;
@@ -2437,7 +2409,6 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfr
rtw_addbareq_cmd(padapter, (u8) priority, pattrib->ra);
}
}
-
}
void rtw_append_exented_cap(struct adapter *padapter, u8 *out_ie, uint *pout_len)
--
2.39.5
next prev parent reply other threads:[~2025-07-26 4:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-26 4:31 [PATCH 00/20] rtl8723bs: cleanup and style improvements for better readability Vivek BalachandharTN
2025-07-26 4:31 ` [PATCH 01/20] staging: rtl8723bs: fix spacing around operators Vivek BalachandharTN
2025-07-26 4:32 ` Vivek BalachandharTN [this message]
2025-07-26 4:32 ` [PATCH 03/20] staging: rtl8723bs: add blank line after function declaration Vivek BalachandharTN
2025-07-28 4:36 ` [PATCH v1 03/20] staging: rtl8723bs: add blank line between rtw_roaming() and _rtw_roaming() Vivek BalachandharTN
2025-07-30 4:04 ` [PATCH v2 " Vivek BalachandharTN
2025-07-30 4:20 ` [PATCH v3 " Vivek BalachandharTN
2025-07-30 7:32 ` [PATCH v4 " Vivek BalachandharTN
2025-07-30 19:06 ` Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 04/20] staging: rtl8723bs: remove unnecessary space after type cast Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 05/20] staging: rtl8723bs: remove space before tabs Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 06/20] staging: rtl8723bs: fix overlong lines and clarify lengthy comments Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 07/20] staging: rtl8723bs: align asterisk in block comment to fix formatting Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 08/20] staging: rtl8723bs: fix logical continuation style by moving to previous line Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 09/20] staging: rtl8723bs: fix indentation to align with open parenthesis Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 10/20] staging: rtl8723bs: adding asterisks in multi-line block comments Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 11/20] staging: rtl8723bs: remove space before semicolon Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 12/20] staging: rtl8723bs: fix excessive indentation in nested if statement Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 13/20] staging: rtl8723bs: fix unbalanced braces around conditional blocks Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 14/20] staging: rtl8723bs: remove unnecessary parentheses around assignment Vivek BalachandharTN
2025-07-28 6:35 ` [PATCH v1 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional Vivek BalachandharTN
2025-07-28 6:43 ` [PATCH v2 " Vivek BalachandharTN
2025-07-30 8:03 ` [PATCH v3 " Vivek BalachandharTN
2025-07-30 18:39 ` [PATCH " Vivek BalachandharTN
2025-07-30 18:42 ` [PATCH v4 " Vivek BalachandharTN
2025-07-31 1:57 ` Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 15/20] staging: rtl8723bs: remove unnecessary braces for single statement blocks Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 16/20] staging: rtl8723bs: add braces to all arms of conditional statement Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 17/20] staging: rtl8723bs: add blank line after variable declarations Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 18/20] staging: rtl8723bs: fix line ending with '(' Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 19/20] staging: rtl8723bs: place constant on right side of comparison Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 20/20] staging: rtl8723bs: merge nested if conditions for clarity and tab problems Vivek BalachandharTN
2025-07-31 5:29 ` [PATCH 00/20] rtl8723bs: cleanup and style improvements for better readability Greg KH
2025-07-31 13:50 ` Feedback on Patch Submissions Vivek BalachandharTN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250726043218.386738-3-vivek.balachandhar@gmail.com \
--to=vivek.balachandhar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).