From: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
vivek.balachandhar@gmail.com
Subject: [PATCH v1 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional
Date: Mon, 28 Jul 2025 06:35:10 +0000 [thread overview]
Message-ID: <20250728063510.422849-1-vivek.balachandhar@gmail.com> (raw)
In-Reply-To: <20250726043218.386738-15-vivek.balachandhar@gmail.com>
Removed superfluous parentheses around a function call inside an
if-condition. These extra parentheses are not required and violate
kernel coding style guidelines.
Cleaning them up improves code readability without changing logic.
Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
v2:
- Fixed incorrect wording: the change was not around assignment
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 3702d7e7a954..d845eaecd615 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -700,7 +700,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
rtw_set_signal_stat_timer(&adapter->recvpriv);
if (pmlmepriv->to_join) {
- if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
+ if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true) {
if (check_fwstate(pmlmepriv, _FW_LINKED) == false) {
set_fwstate(pmlmepriv, _FW_UNDER_LINKING);
--
2.39.5
next prev parent reply other threads:[~2025-07-28 6:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-26 4:31 [PATCH 00/20] rtl8723bs: cleanup and style improvements for better readability Vivek BalachandharTN
2025-07-26 4:31 ` [PATCH 01/20] staging: rtl8723bs: fix spacing around operators Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 02/20] staging: rtl8723bs: remove unnecessary blank lines around braces Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 03/20] staging: rtl8723bs: add blank line after function declaration Vivek BalachandharTN
2025-07-28 4:36 ` [PATCH v1 03/20] staging: rtl8723bs: add blank line between rtw_roaming() and _rtw_roaming() Vivek BalachandharTN
2025-07-30 4:04 ` [PATCH v2 " Vivek BalachandharTN
2025-07-30 4:20 ` [PATCH v3 " Vivek BalachandharTN
2025-07-30 7:32 ` [PATCH v4 " Vivek BalachandharTN
2025-07-30 19:06 ` Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 04/20] staging: rtl8723bs: remove unnecessary space after type cast Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 05/20] staging: rtl8723bs: remove space before tabs Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 06/20] staging: rtl8723bs: fix overlong lines and clarify lengthy comments Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 07/20] staging: rtl8723bs: align asterisk in block comment to fix formatting Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 08/20] staging: rtl8723bs: fix logical continuation style by moving to previous line Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 09/20] staging: rtl8723bs: fix indentation to align with open parenthesis Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 10/20] staging: rtl8723bs: adding asterisks in multi-line block comments Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 11/20] staging: rtl8723bs: remove space before semicolon Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 12/20] staging: rtl8723bs: fix excessive indentation in nested if statement Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 13/20] staging: rtl8723bs: fix unbalanced braces around conditional blocks Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 14/20] staging: rtl8723bs: remove unnecessary parentheses around assignment Vivek BalachandharTN
2025-07-28 6:35 ` Vivek BalachandharTN [this message]
2025-07-28 6:43 ` [PATCH v2 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional Vivek BalachandharTN
2025-07-30 8:03 ` [PATCH v3 " Vivek BalachandharTN
2025-07-30 18:39 ` [PATCH " Vivek BalachandharTN
2025-07-30 18:42 ` [PATCH v4 " Vivek BalachandharTN
2025-07-31 1:57 ` Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 15/20] staging: rtl8723bs: remove unnecessary braces for single statement blocks Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 16/20] staging: rtl8723bs: add braces to all arms of conditional statement Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 17/20] staging: rtl8723bs: add blank line after variable declarations Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 18/20] staging: rtl8723bs: fix line ending with '(' Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 19/20] staging: rtl8723bs: place constant on right side of comparison Vivek BalachandharTN
2025-07-26 4:32 ` [PATCH 20/20] staging: rtl8723bs: merge nested if conditions for clarity and tab problems Vivek BalachandharTN
2025-07-31 5:29 ` [PATCH 00/20] rtl8723bs: cleanup and style improvements for better readability Greg KH
2025-07-31 13:50 ` Feedback on Patch Submissions Vivek BalachandharTN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728063510.422849-1-vivek.balachandhar@gmail.com \
--to=vivek.balachandhar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).