From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: iio: adc: ad7816: Drop unnecessary dev_set_drvdata() call
Date: Tue, 19 Aug 2025 19:20:44 +0100 [thread overview]
Message-ID: <20250819192044.5637c96b@jic23-huawei> (raw)
In-Reply-To: <f7815955-7e8a-4f67-b699-8b19cb38683a@baylibre.com>
On Tue, 19 Aug 2025 10:05:09 -0500
David Lechner <dlechner@baylibre.com> wrote:
> On 8/19/25 10:00 AM, Salah Triki wrote:
> > Remove the call to `dev_set_drvdata()` and the associated comment
> > since private data is never read.
> >
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> > Changes in v2 :
>
> Reviewed-by: David Lechner <dlechner@baylibre.com>
Applied, thanks!
This motivated to do my periodic can I drop this driver yet check
against my usual rule of once it's obsolete from the supplier and
no significant work on the driver (staging only I'm less keen to remove
drives in good condition!)
Unfortunately 7817 which it supports is still in production :(
I then checked the other drivers still there and they all cover production
parts as well.
This is a pretty simple device and probably a good target for someone
who wants to try their first driver. It would be a near rewrite as this
code is miles off ABI wise.
Doesn't look like there is a currently available dev board, but it's
available in a TSSOP and will run on wide range of voltages so not
a challenge for someone to give a go on a break out board.
Just thought I'd mention that and see if anyone jumped on it ;)
Jonathan
p.s. One day I'll just decide to delete all the remaining staging drivers.
Analog folk, they are all yours! I can't blame any of you though
as I think the first stuff from Michael was the following year.
prev parent reply other threads:[~2025-08-19 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 15:00 [PATCH v2] staging: iio: adc: ad7816: Drop unnecessary dev_set_drvdata() call Salah Triki
2025-08-19 15:05 ` David Lechner
2025-08-19 18:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819192044.5637c96b@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox