* [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c
@ 2025-09-08 14:46 Akiyoshi Kurita
2025-09-08 15:24 ` Dan Carpenter
2025-09-12 13:45 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Akiyoshi Kurita @ 2025-09-08 14:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Philipp Hortmann, linux-staging, linux-kernel
Cc: Akiyoshi Kurita
The function definition for phy_StoreTxPowerByRateBase() did not
follow the kernel coding style.
Move the closing parenthesis to the same line as the argument to fix
the style issue reported by checkpatch.pl.
Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index d5649e7d8f99..f137ec747ab3 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
}
static void
-phy_StoreTxPowerByRateBase(
-struct adapter *padapter
- )
+phy_StoreTxPowerByRateBase(struct adapter *padapter)
{
u8 path, base;
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c
2025-09-08 14:46 [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c Akiyoshi Kurita
@ 2025-09-08 15:24 ` Dan Carpenter
2025-09-12 13:45 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-09-08 15:24 UTC (permalink / raw)
To: Akiyoshi Kurita
Cc: Greg Kroah-Hartman, Philipp Hortmann, linux-staging, linux-kernel
On Mon, Sep 08, 2025 at 11:46:41PM +0900, Akiyoshi Kurita wrote:
> The function definition for phy_StoreTxPowerByRateBase() did not
> follow the kernel coding style.
>
> Move the closing parenthesis to the same line as the argument to fix
> the style issue reported by checkpatch.pl.
>
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
There are so many other functions which are declared in exactly this
same format. Fix the others like this in the file as well in one patch.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c
2025-09-08 14:46 [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c Akiyoshi Kurita
2025-09-08 15:24 ` Dan Carpenter
@ 2025-09-12 13:45 ` Greg Kroah-Hartman
2025-09-12 16:26 ` [PATCH v2] staging: rtl8723bs: hal: put return type and function name on one line Akiyoshi Kurita
1 sibling, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2025-09-12 13:45 UTC (permalink / raw)
To: Akiyoshi Kurita; +Cc: Philipp Hortmann, linux-staging, linux-kernel
On Mon, Sep 08, 2025 at 11:46:41PM +0900, Akiyoshi Kurita wrote:
> The function definition for phy_StoreTxPowerByRateBase() did not
> follow the kernel coding style.
>
> Move the closing parenthesis to the same line as the argument to fix
> the style issue reported by checkpatch.pl.
>
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
> drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> index d5649e7d8f99..f137ec747ab3 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> @@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
> }
>
> static void
> -phy_StoreTxPowerByRateBase(
> -struct adapter *padapter
> - )
> +phy_StoreTxPowerByRateBase(struct adapter *padapter)
This really should end up being:
static void phy_StoreTxPowerByRateBase(struct adapter *padapter)
right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] staging: rtl8723bs: hal: put return type and function name on one line
2025-09-12 13:45 ` Greg Kroah-Hartman
@ 2025-09-12 16:26 ` Akiyoshi Kurita
0 siblings, 0 replies; 4+ messages in thread
From: Akiyoshi Kurita @ 2025-09-12 16:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Akiyoshi Kurita
Make the function definition of phy_StoreTxPowerByRateBase() follow the
kernel coding style by placing the return type and function name on a
single line.
No functional change.
Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
---
v2:
- Keep return type and function name on the same line (per review).
- Drop stray blank line before the opening brace.
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index d5649e7d8f99..cd76e26e868f 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -59,10 +59,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
}
}
-static void
-phy_StoreTxPowerByRateBase(
-struct adapter *padapter
- )
+static void phy_StoreTxPowerByRateBase(struct adapter *padapter)
{
u8 path, base;
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-12 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-08 14:46 [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c Akiyoshi Kurita
2025-09-08 15:24 ` Dan Carpenter
2025-09-12 13:45 ` Greg Kroah-Hartman
2025-09-12 16:26 ` [PATCH v2] staging: rtl8723bs: hal: put return type and function name on one line Akiyoshi Kurita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).