* [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner
@ 2025-09-09 3:58 Akiyoshi Kurita
2025-09-09 4:43 ` Greg KH
2025-09-09 5:33 ` [PATCH v2 1/2] " Akiyoshi Kurita
0 siblings, 2 replies; 6+ messages in thread
From: Akiyoshi Kurita @ 2025-09-09 3:58 UTC (permalink / raw)
To: gregkh, Philipp Hortmann; +Cc: linux-staging, linux-kernel, Akiyoshi Kurita
Replace the banner-style copyright comment with a single-line comment.
No functional changes.
Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
---
drivers/staging/rtl8723bs/include/rtw_efuse.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index 669565fa1c69..d791e35db769 100644
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -1,9 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
-/******************************************************************************
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- ******************************************************************************/
+/* Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. */
+
#ifndef __RTW_EFUSE_H__
#define __RTW_EFUSE_H__
@@ -95,7 +92,7 @@ void EFUSE_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 type, v
u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data, bool bPseudoTest);
u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest);
-void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
+void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address);
void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoTest);
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner
2025-09-09 3:58 [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner Akiyoshi Kurita
@ 2025-09-09 4:43 ` Greg KH
2025-09-09 5:36 ` weibu
2025-09-09 5:33 ` [PATCH v2 1/2] " Akiyoshi Kurita
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2025-09-09 4:43 UTC (permalink / raw)
To: Akiyoshi Kurita; +Cc: Philipp Hortmann, linux-staging, linux-kernel
On Tue, Sep 09, 2025 at 12:58:04PM +0900, Akiyoshi Kurita wrote:
> Replace the banner-style copyright comment with a single-line comment.
> No functional changes.
>
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
> drivers/staging/rtl8723bs/include/rtw_efuse.h | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
> index 669565fa1c69..d791e35db769 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
> @@ -1,9 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -/******************************************************************************
> - *
> - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
> - *
> - ******************************************************************************/
> +/* Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. */
> +
> #ifndef __RTW_EFUSE_H__
> #define __RTW_EFUSE_H__
>
> @@ -95,7 +92,7 @@ void EFUSE_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 type, v
> u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data, bool bPseudoTest);
> u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest);
>
> -void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
> +void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
This doesn't look like a copyright banner change :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner
2025-09-09 3:58 [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner Akiyoshi Kurita
2025-09-09 4:43 ` Greg KH
@ 2025-09-09 5:33 ` Akiyoshi Kurita
2025-09-09 5:33 ` [PATCH v2 2/2] staging: rtl8723bs: rtw_efuse.h: fix double space in PwrState parameter Akiyoshi Kurita
1 sibling, 1 reply; 6+ messages in thread
From: Akiyoshi Kurita @ 2025-09-09 5:33 UTC (permalink / raw)
To: gregkh, Philipp Hortmann; +Cc: linux-staging, linux-kernel, Akiyoshi Kurita
Replace the banner-style copyright comment with a single-line comment.
No functional changes.
Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
---
drivers/staging/rtl8723bs/include/rtw_efuse.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index 669565fa1c69..ac7d6ef454c3 100644
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -1,9 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
-/******************************************************************************
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- ******************************************************************************/
+/* Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. */
+
#ifndef __RTW_EFUSE_H__
#define __RTW_EFUSE_H__
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] staging: rtl8723bs: rtw_efuse.h: fix double space in PwrState parameter
2025-09-09 5:33 ` [PATCH v2 1/2] " Akiyoshi Kurita
@ 2025-09-09 5:33 ` Akiyoshi Kurita
2025-09-12 13:53 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Akiyoshi Kurita @ 2025-09-09 5:33 UTC (permalink / raw)
To: gregkh, Philipp Hortmann; +Cc: linux-staging, linux-kernel, Akiyoshi Kurita
Fix coding style by removing a double space before the PwrState parameter.
No functional changes.
Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
---
drivers/staging/rtl8723bs/include/rtw_efuse.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index ac7d6ef454c3..d791e35db769 100644
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -92,7 +92,7 @@ void EFUSE_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 type, v
u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data, bool bPseudoTest);
u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest);
-void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
+void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address);
void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoTest);
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner
2025-09-09 4:43 ` Greg KH
@ 2025-09-09 5:36 ` weibu
0 siblings, 0 replies; 6+ messages in thread
From: weibu @ 2025-09-09 5:36 UTC (permalink / raw)
To: Greg KH; +Cc: Philipp Hortmann, linux-staging, linux-kernel
Hi Greg,
Thanks for your feedback. You were right — I had mixed two changes in
one patch.
I’ve now split them and resent as v2:
[PATCH v2 1/2] simplify copyright banner
[PATCH v2 2/2] fix double space in PwrState parameter
Sorry for the noise, and thank you for your review.
Best regards,
Akiyoshi Kurita
On 2025-09-09 13:43, Greg KH wrote:
> On Tue, Sep 09, 2025 at 12:58:04PM +0900, Akiyoshi Kurita wrote:
>> Replace the banner-style copyright comment with a single-line comment.
>> No functional changes.
>>
>> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
>> ---
>> drivers/staging/rtl8723bs/include/rtw_efuse.h | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h
>> b/drivers/staging/rtl8723bs/include/rtw_efuse.h
>> index 669565fa1c69..d791e35db769 100644
>> --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
>> +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
>> @@ -1,9 +1,6 @@
>> /* SPDX-License-Identifier: GPL-2.0 */
>> -/******************************************************************************
>> - *
>> - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
>> - *
>> -
>> ******************************************************************************/
>> +/* Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
>> */
>> +
>> #ifndef __RTW_EFUSE_H__
>> #define __RTW_EFUSE_H__
>>
>> @@ -95,7 +92,7 @@ void EFUSE_GetEfuseDefinition(struct adapter
>> *padapter, u8 efuseType, u8 type, v
>> u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data,
>> bool bPseudoTest);
>> u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data,
>> bool bPseudoTest);
>>
>> -void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8
>> PwrState);
>> +void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8
>> PwrState);
>
> This doesn't look like a copyright banner change :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] staging: rtl8723bs: rtw_efuse.h: fix double space in PwrState parameter
2025-09-09 5:33 ` [PATCH v2 2/2] staging: rtl8723bs: rtw_efuse.h: fix double space in PwrState parameter Akiyoshi Kurita
@ 2025-09-12 13:53 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2025-09-12 13:53 UTC (permalink / raw)
To: Akiyoshi Kurita; +Cc: Philipp Hortmann, linux-staging, linux-kernel
On Tue, Sep 09, 2025 at 02:33:27PM +0900, Akiyoshi Kurita wrote:
> Fix coding style by removing a double space before the PwrState parameter.
> No functional changes.
>
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
> drivers/staging/rtl8723bs/include/rtw_efuse.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
> index ac7d6ef454c3..d791e35db769 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
> @@ -92,7 +92,7 @@ void EFUSE_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 type, v
> u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data, bool bPseudoTest);
> u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest);
>
> -void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
> +void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
>
> u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address);
> void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoTest);
> --
> 2.47.3
>
>
This patch did not apply, what tree and branch did you make it against?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-12 13:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-09 3:58 [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner Akiyoshi Kurita
2025-09-09 4:43 ` Greg KH
2025-09-09 5:36 ` weibu
2025-09-09 5:33 ` [PATCH v2 1/2] " Akiyoshi Kurita
2025-09-09 5:33 ` [PATCH v2 2/2] staging: rtl8723bs: rtw_efuse.h: fix double space in PwrState parameter Akiyoshi Kurita
2025-09-12 13:53 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).