public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rohan Tripathi <trohan2000@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: clean up style in rtw_ap.c
Date: Sun, 5 Oct 2025 16:23:56 +0200	[thread overview]
Message-ID: <2025100523-kilt-feline-bada@gregkh> (raw)
In-Reply-To: <20251005135525.314476-1-trohan2000@gmail.com>

On Sun, Oct 05, 2025 at 09:55:25AM -0400, Rohan Tripathi wrote:
> @@ -480,14 +481,13 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
>  		/* check if sta supports rx ampdu */
>  		phtpriv_sta->ampdu_enable = phtpriv_ap->ampdu_enable;
>  
> -		phtpriv_sta->rx_ampdu_min_spacing = (
> -			phtpriv_sta->ht_cap.ampdu_params_info & IEEE80211_HT_CAP_AMPDU_DENSITY
> +		phtpriv_sta->rx_ampdu_min_spacing = (phtpriv_sta->ht_cap.ampdu_params_info &
> +		IEEE80211_HT_CAP_AMPDU_DENSITY
>  		) >> 2;

These lines do not look right even after this change, do they?  We can
do better :)

thanks,

greg k-h

  parent reply	other threads:[~2025-10-05 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-05 13:55 [PATCH] staging: rtl8723bs: clean up style in rtw_ap.c Rohan Tripathi
2025-10-05 14:23 ` Greg KH
2025-10-05 14:23 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-05 15:59 [PATCH 1/4] staging: rtl8723bs: clean up lines ending with '(' " Rohan Tripathi
2025-10-05 15:59 ` [PATCH] staging: rtl8723bs: clean up style " Rohan Tripathi
2025-10-06  7:29   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025100523-kilt-feline-bada@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=trohan2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox