From: Jonathan Cameron <jic23@kernel.org>
To: Taimoor Zaeem <taimoorzaeem@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/2] staging: iio: ad9834: remove empty ad9834.h file
Date: Sun, 12 Oct 2025 15:17:55 +0100 [thread overview]
Message-ID: <20251012151755.24db56ea@jic23-huawei> (raw)
In-Reply-To: <20251006094025.259440-2-taimoorzaeem@gmail.com>
On Mon, 6 Oct 2025 14:40:24 +0500
Taimoor Zaeem <taimoorzaeem@gmail.com> wrote:
> Remove drivers/staging/iio/frequency/ad9834.h header file
> because it contains nothing except the include guards.
>
Odd! I guess left over after some other cleanup at somepoint.
Applied.
Thanks for cleaning this up.
Jonathan
> Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
> ---
> drivers/staging/iio/frequency/ad9834.c | 3 +--
> drivers/staging/iio/frequency/ad9834.h | 10 ----------
> 2 files changed, 1 insertion(+), 12 deletions(-)
> delete mode 100644 drivers/staging/iio/frequency/ad9834.h
>
> diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
> index 0038eb234d40..d339d5e8e043 100644
> --- a/drivers/staging/iio/frequency/ad9834.c
> +++ b/drivers/staging/iio/frequency/ad9834.c
> @@ -21,9 +21,8 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dds.h"
>
> -#include "ad9834.h"
> +#include "dds.h"
>
> /* Registers */
>
> diff --git a/drivers/staging/iio/frequency/ad9834.h b/drivers/staging/iio/frequency/ad9834.h
> deleted file mode 100644
> index 521943aa0e61..000000000000
> --- a/drivers/staging/iio/frequency/ad9834.h
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -/*
> - * AD9833/AD9834/AD9837/AD9838 SPI DDS driver
> - *
> - * Copyright 2010-2011 Analog Devices Inc.
> - */
> -#ifndef IIO_DDS_AD9834_H_
> -#define IIO_DDS_AD9834_H_
> -
> -#endif /* IIO_DDS_AD9834_H_ */
next prev parent reply other threads:[~2025-10-12 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 9:40 [PATCH 0/2] Remove ad9832.h and ad9834.h header files in drivers/staging/iio/frequency Taimoor Zaeem
2025-10-06 9:40 ` [PATCH 1/2] staging: iio: ad9834: remove empty ad9834.h file Taimoor Zaeem
2025-10-12 14:17 ` Jonathan Cameron [this message]
2025-10-06 9:40 ` [PATCH 2/2] staging: iio: ad9832: move struct ad9832_platform_data to ad9832.c Taimoor Zaeem
2025-10-07 12:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251012151755.24db56ea@jic23-huawei \
--to=jic23@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=taimoorzaeem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox