* [PATCH] staging: nvec: remove NVEC_PS2_DEBUG and dead debug macro
@ 2025-10-16 14:53 Emre Cecanpunar
2025-10-16 17:53 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Emre Cecanpunar @ 2025-10-16 14:53 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, Emre Cecanpunar
The NVEC_PS2_DEBUG macro and NVEC_PHD() are unused and only add clutter.
Remove them completely.
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Emre Cecanpunar <emreleno@gmail.com>
---
drivers/staging/nvec/nvec_ps2.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index 575233fa1677..c89f3de0654c 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -23,14 +23,6 @@
#define DISABLE_MOUSE 0xf5
#define PSMOUSE_RST 0xff
-#ifdef NVEC_PS2_DEBUG
-#define NVEC_PHD(str, buf, len) \
- print_hex_dump(KERN_DEBUG, str, DUMP_PREFIX_NONE, \
- 16, 1, buf, len, false)
-#else
-#define NVEC_PHD(str, buf, len) do { } while (0)
-#endif
-
enum ps2_subcmds {
SEND_COMMAND = 1,
RECEIVE_N,
@@ -70,18 +62,15 @@ static int nvec_ps2_notifier(struct notifier_block *nb,
case NVEC_PS2_EVT:
for (i = 0; i < msg[1]; i++)
serio_interrupt(ps2_dev.ser_dev, msg[2 + i], 0);
- NVEC_PHD("ps/2 mouse event: ", &msg[2], msg[1]);
return NOTIFY_STOP;
case NVEC_PS2:
if (msg[2] == 1) {
for (i = 0; i < (msg[1] - 2); i++)
serio_interrupt(ps2_dev.ser_dev, msg[i + 4], 0);
- NVEC_PHD("ps/2 mouse reply: ", &msg[4], msg[1] - 2);
}
else if (msg[1] != 2) /* !ack */
- NVEC_PHD("unhandled mouse event: ", msg, msg[1] + 2);
return NOTIFY_STOP;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: nvec: remove NVEC_PS2_DEBUG and dead debug macro
2025-10-16 14:53 [PATCH] staging: nvec: remove NVEC_PS2_DEBUG and dead debug macro Emre Cecanpunar
@ 2025-10-16 17:53 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-10-16 17:53 UTC (permalink / raw)
To: Emre Cecanpunar; +Cc: gregkh, linux-staging
On Thu, Oct 16, 2025 at 05:53:24PM +0300, Emre Cecanpunar wrote:
> @@ -70,18 +62,15 @@ static int nvec_ps2_notifier(struct notifier_block *nb,
> case NVEC_PS2_EVT:
> for (i = 0; i < msg[1]; i++)
> serio_interrupt(ps2_dev.ser_dev, msg[2 + i], 0);
> - NVEC_PHD("ps/2 mouse event: ", &msg[2], msg[1]);
> return NOTIFY_STOP;
>
> case NVEC_PS2:
> if (msg[2] == 1) {
> for (i = 0; i < (msg[1] - 2); i++)
> serio_interrupt(ps2_dev.ser_dev, msg[i + 4], 0);
> - NVEC_PHD("ps/2 mouse reply: ", &msg[4], msg[1] - 2);
> }
>
> else if (msg[1] != 2) /* !ack */
> - NVEC_PHD("unhandled mouse event: ", msg, msg[1] + 2);
This will introduce a bug.
regards,
dan carpenter
> return NOTIFY_STOP;
> }
>
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: nvec: remove NVEC_PS2_DEBUG and dead debug macro
@ 2025-10-18 10:01 Emre Cecanpunar
0 siblings, 0 replies; 3+ messages in thread
From: Emre Cecanpunar @ 2025-10-18 10:01 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, Emre Cecanpunar
The NVEC_PS2_DEBUG macro and NVEC_PHD() are unused and only add clutter.
Remove them completely.
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Emre Cecanpunar <emreleno@gmail.com>
---
drivers/staging/nvec/nvec_ps2.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index 575233fa1677..2db57795ea2f 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -23,14 +23,6 @@
#define DISABLE_MOUSE 0xf5
#define PSMOUSE_RST 0xff
-#ifdef NVEC_PS2_DEBUG
-#define NVEC_PHD(str, buf, len) \
- print_hex_dump(KERN_DEBUG, str, DUMP_PREFIX_NONE, \
- 16, 1, buf, len, false)
-#else
-#define NVEC_PHD(str, buf, len) do { } while (0)
-#endif
-
enum ps2_subcmds {
SEND_COMMAND = 1,
RECEIVE_N,
@@ -70,18 +62,14 @@ static int nvec_ps2_notifier(struct notifier_block *nb,
case NVEC_PS2_EVT:
for (i = 0; i < msg[1]; i++)
serio_interrupt(ps2_dev.ser_dev, msg[2 + i], 0);
- NVEC_PHD("ps/2 mouse event: ", &msg[2], msg[1]);
return NOTIFY_STOP;
case NVEC_PS2:
if (msg[2] == 1) {
for (i = 0; i < (msg[1] - 2); i++)
serio_interrupt(ps2_dev.ser_dev, msg[i + 4], 0);
- NVEC_PHD("ps/2 mouse reply: ", &msg[4], msg[1] - 2);
}
- else if (msg[1] != 2) /* !ack */
- NVEC_PHD("unhandled mouse event: ", msg, msg[1] + 2);
return NOTIFY_STOP;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-18 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 14:53 [PATCH] staging: nvec: remove NVEC_PS2_DEBUG and dead debug macro Emre Cecanpunar
2025-10-16 17:53 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2025-10-18 10:01 Emre Cecanpunar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).