From: Greg KH <gregkh@linuxfoundation.org>
To: Dharanitharan R <dharanitharan725@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH v4] staging: rtl8723bs: use ether_addr_copy() and simplify NULL checks
Date: Thu, 23 Oct 2025 11:57:24 +0200 [thread overview]
Message-ID: <2025102338-sandbank-croak-5f1d@gregkh> (raw)
In-Reply-To: <20251023093052.1822-1-dharanitharan725@gmail.com>
On Thu, Oct 23, 2025 at 09:30:52AM +0000, Dharanitharan R wrote:
> This patch replaces multiple memcpy() calls with ether_addr_copy()
> for copying MAC/Ethernet addresses in rtl8723bs.
Take a look at the documentation for the kernel on how to write good
changelog text. It's usually the hardest part of writing a patch. It
says to not do things that say "this patch" and the like.
Also, your Subject doesn't make sense, there is no NULL checks happening
here.
>
> These changes improve code clarity, align with Linux kernel best
> practices, and fix checkpatch.pl warnings.
What warning is being handled?
>
> Tested by compiling the module successfully with:
> make M=drivers/staging/rtl8723bs
That doesn't always work, better to use:
make drivers/staging/rtl8723bs/
Also, that is always implied, and shouldn't be needed here :)
thanks,
greg k-h
prev parent reply other threads:[~2025-10-23 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 9:30 [PATCH v4] staging: rtl8723bs: use ether_addr_copy() and simplify NULL checks Dharanitharan R
2025-10-23 9:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025102338-sandbank-croak-5f1d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dharanitharan725@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox