[PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro

[PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro

[rafiqul713]

From: Rafiqul Islam <rafiqul713@gmail.com>

The rtw_sprintf macro is defined but never used anywhere in
drivers/staging/rtl8723bs. Remove it to clean up the code.

Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
---
 drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 8b1634f4091e..12369ee2ce1d 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -115,10 +115,4 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf);
 void *rtw_cbuf_pop(struct rtw_cbuf *cbuf);
 struct rtw_cbuf *rtw_cbuf_alloc(u32 size);
 
-/*  String handler */
-/*
- * Write formatted output to sized buffer
- */
-#define rtw_sprintf(buf, size, format, arg...)	snprintf(buf, size, format, ##arg)
-
 #endif
-- 
2.34.1

Re: [PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro

[Greg KH]

On Sun, Oct 26, 2025 at 10:32:41AM +0100, rafiqul713 wrote:
> From: Rafiqul Islam <rafiqul713@gmail.com>
> 
> The rtw_sprintf macro is defined but never used anywhere in
> drivers/staging/rtl8723bs. Remove it to clean up the code.
> 
> Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
> index 8b1634f4091e..12369ee2ce1d 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service.h
> @@ -115,10 +115,4 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf);
>  void *rtw_cbuf_pop(struct rtw_cbuf *cbuf);
>  struct rtw_cbuf *rtw_cbuf_alloc(u32 size);
>  
> -/*  String handler */
> -/*
> - * Write formatted output to sized buffer
> - */
> -#define rtw_sprintf(buf, size, format, arg...)	snprintf(buf, size, format, ##arg)
> -
>  #endif
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro

[rafiqul713]

From: Rafiqul Islam <rafiqul713@gmail.com>

This patch removes the rtw_sprintf macro from drivers/staging/rtl8723bs/include/osdep_service.h.
It was defined but never used anywhere in the driver.

Changes since v1:
- Instead of replacing rtw_sprintf with scnprintf, we realized the macro is unused.
- Removed it entirely to clean up the code.

No functional changes are expected.

Tested: module build works without issues.

Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
---
 drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 8b1634f4091e..12369ee2ce1d 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -115,10 +115,4 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf);
 void *rtw_cbuf_pop(struct rtw_cbuf *cbuf);
 struct rtw_cbuf *rtw_cbuf_alloc(u32 size);
 
-/*  String handler */
-/*
- * Write formatted output to sized buffer
- */
-#define rtw_sprintf(buf, size, format, arg...)	snprintf(buf, size, format, ##arg)
-
 #endif
-- 
2.34.1

Re: [PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro

[Greg KH]

On Sun, Oct 26, 2025 at 10:49:25AM +0100, rafiqul713 wrote:
> From: Rafiqul Islam <rafiqul713@gmail.com>
> 
> This patch removes the rtw_sprintf macro from drivers/staging/rtl8723bs/include/osdep_service.h.
> It was defined but never used anywhere in the driver.
> 
> Changes since v1:
> - Instead of replacing rtw_sprintf with scnprintf, we realized the macro is unused.
> - Removed it entirely to clean up the code.

Please slow down, take a day or two, and go read all of the links that
were provided for you on how to do this properly, and THEN submit a new
version.  There is no rush here.

> No functional changes are expected.
> 
> Tested: module build works without issues.

This type of testing is always expected, no need to say so.

thanks,

greg k-h

[PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro

[rafiqul713]

From: Rafiqul Islam <rafiqul713@gmail.com>

This patch removes the rtw_sprintf macro from drivers/staging/rtl8723bs/include/osdep_service.h.
It was defined but never used anywhere in the driver.

Changes since v1:
- Instead of replacing rtw_sprintf with scnprintf, we realized the macro is unused.
- Removed it entirely to clean up the code.

Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
---
 drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 8b1634f4091e..12369ee2ce1d 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -115,10 +115,4 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf);
 void *rtw_cbuf_pop(struct rtw_cbuf *cbuf);
 struct rtw_cbuf *rtw_cbuf_alloc(u32 size);
 
-/*  String handler */
-/*
- * Write formatted output to sized buffer
- */
-#define rtw_sprintf(buf, size, format, arg...)	snprintf(buf, size, format, ##arg)
-
 #endif
-- 
2.34.1