From: Greg KH <gregkh@linuxfoundation.org>
To: rafiqul713 <rafiqul713@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro
Date: Sun, 26 Oct 2025 10:54:19 +0100 [thread overview]
Message-ID: <2025102618-tactile-quack-6693@gregkh> (raw)
In-Reply-To: <20251026094925.171310-1-rafiqul713@gmail.com>
On Sun, Oct 26, 2025 at 10:49:25AM +0100, rafiqul713 wrote:
> From: Rafiqul Islam <rafiqul713@gmail.com>
>
> This patch removes the rtw_sprintf macro from drivers/staging/rtl8723bs/include/osdep_service.h.
> It was defined but never used anywhere in the driver.
>
> Changes since v1:
> - Instead of replacing rtw_sprintf with scnprintf, we realized the macro is unused.
> - Removed it entirely to clean up the code.
Please slow down, take a day or two, and go read all of the links that
were provided for you on how to do this properly, and THEN submit a new
version. There is no rush here.
> No functional changes are expected.
>
> Tested: module build works without issues.
This type of testing is always expected, no need to say so.
thanks,
greg k-h
next prev parent reply other threads:[~2025-10-26 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 9:49 [PATCH] [PATCH v2] staging: rtl8723bs: remove unused rtw_sprintf macro rafiqul713
2025-10-26 9:54 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-26 10:02 rafiqul713
2025-10-26 9:32 rafiqul713
2025-10-26 9:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025102618-tactile-quack-6693@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=rafiqul713@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox