Re: [PATCH] staging: rtl8723bs: replace rtw_sprintf with scnprintf

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Oct 26, 2025 at 10:04:38AM +0100, rafiqul713 wrote:
> From: Rafiqul Islam <rafiqul713@gmail.com>
> 
> The rtw_sprintf macro used an old-style varargs macro. Replace it with scnprintf()
> to ensure buffer bounds are honoured and to align with kernel conventions.
> This change is a safe refactor (no functional change) and improves robustness
> against potential buffer overruns.
> 
> Tested: built driver tree (module build) and no runtime changes expected.
> 
> Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/osdep_service.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
> index 8b1634f4091e..019792d0595a 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service.h
> @@ -119,6 +119,6 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size);
>  /*
>   * Write formatted output to sized buffer
>   */
> -#define rtw_sprintf(buf, size, format, arg...)	snprintf(buf, size, format, ##arg)
> +#define rtw_sprintf(buf, size, fmt, ...) scnprintf(buf, size, fmt, ##__VA_ARGS__)

Why change this at all, it is not used anywhere, so why not just delete
this?

And this is the second version of this patch, it should have been "v2",
right?

thanks,

greg k-h