From: Greg KH <gregkh@linuxfoundation.org>
To: rafiqul713 <rafiqul713@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH v4] staging: rtl8723bs: remove unused rtw_sprintf macro
Date: Tue, 28 Oct 2025 10:26:57 +0100 [thread overview]
Message-ID: <2025102806-gutless-follow-db99@gregkh> (raw)
In-Reply-To: <20251028092022.80186-1-rafiqul713@gmail.com>
On Tue, Oct 28, 2025 at 10:20:22AM +0100, rafiqul713 wrote:
> From: Rafiqul Islam <rafiqul713@gmail.com>
>
> The rtw_sprintf macro is defined in osdep_service.h but has no callers in
> the driver. Remove the dead code.
>
> Changes since v2:
> - Addressed review feedback to delete the macro instead of replacing it
>
> Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
> 1 file changed, 6 deletions(-)
{sigh}
Again, go back and take a look at the links my bot pointed you at, to be
specific, read this:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
Take a few more days, relax, and try again. There is no rush here.
greg k-h
next prev parent reply other threads:[~2025-10-28 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 9:20 [PATCH v4] staging: rtl8723bs: remove unused rtw_sprintf macro rafiqul713
2025-10-28 9:26 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-28 9:39 rafiqul713
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025102806-gutless-follow-db99@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=rafiqul713@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).