[PATCH v4] staging: rtl8723bs: remove unused rtw_sprintf macro

[PATCH v4] staging: rtl8723bs: remove unused rtw_sprintf macro

[rafiqul713]

From: Rafiqul Islam <rafiqul713@gmail.com>

The rtw_sprintf macro is defined in osdep_service.h but has no callers in
the driver. Remove the dead code.

Changes since v2:
- Addressed review feedback to delete the macro instead of replacing it

Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
---
 drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 8b1634f4091e..12369ee2ce1d 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -115,10 +115,4 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf);
 void *rtw_cbuf_pop(struct rtw_cbuf *cbuf);
 struct rtw_cbuf *rtw_cbuf_alloc(u32 size);
 
-/*  String handler */
-/*
- * Write formatted output to sized buffer
- */
-#define rtw_sprintf(buf, size, format, arg...)	snprintf(buf, size, format, ##arg)
-
 #endif
-- 
2.34.1

Re: [PATCH v4] staging: rtl8723bs: remove unused rtw_sprintf macro

[Greg KH]

On Tue, Oct 28, 2025 at 10:20:22AM +0100, rafiqul713 wrote:
> From: Rafiqul Islam <rafiqul713@gmail.com>
> 
> The rtw_sprintf macro is defined in osdep_service.h but has no callers in
> the driver. Remove the dead code.
> 
> Changes since v2:
> - Addressed review feedback to delete the macro instead of replacing it
> 
> Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
>  1 file changed, 6 deletions(-)

{sigh}

Again, go back and take a look at the links my bot pointed you at, to be
specific, read this:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

Take a few more days, relax, and try again.  There is no rush here.

greg k-h

[PATCH v4] staging: rtl8723bs: remove unused rtw_sprintf macro

[rafiqul713]

From: Rafiqul Islam <rafiqul713@gmail.com>

The rtw_sprintf macro is defined in osdep_service.h but has no callers
in the driver. Remove the dead code.

Changes since v3:
- Addressed review feedback to delete the macro instead of replacing it

Signed-off-by: Rafiqul Islam <rafiqul713@gmail.com>
---
 drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 8b1634f4091e..12369ee2ce1d 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -115,10 +115,4 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf);
 void *rtw_cbuf_pop(struct rtw_cbuf *cbuf);
 struct rtw_cbuf *rtw_cbuf_alloc(u32 size);
 
-/*  String handler */
-/*
- * Write formatted output to sized buffer
- */
-#define rtw_sprintf(buf, size, format, arg...)	snprintf(buf, size, format, ##arg)
-
 #endif
-- 
2.34.1