* [PATCH] staging: fix various code style issues
@ 2025-11-02 7:42 Chang Junzheng
2025-11-02 11:32 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Chang Junzheng @ 2025-11-02 7:42 UTC (permalink / raw)
To: gregkh, linux-staging; +Cc: linux-kernel
Fix trailing whitespace in rtl8723bs driver and add missing
newlines at end of file in multiple staging drivers.
Changes include:
- Remove trailing whitespace from rtl8723bs/core/rtw_mlme.c
- Add missing newline at EOF for vme_user/vme.c
- Add missing newline at EOF for vme_user/vme_fake.c
- Add missing newline at EOF for vme_user/vme_tsi148.c
This addresses checkpatch.pl warnings about code style compliance.
Signed-off-by: Chang Junzheng <guagua210311@qq.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
drivers/staging/vme_user/vme.c | 1 +
drivers/staging/vme_user/vme_fake.c | 1 +
drivers/staging/vme_user/vme_tsi148.c | 1 +
4 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index c06d990350e6..778b8715cdb2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2024,7 +2024,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_
return ielength;
}
-/* Ported from 8185: IsInPreAuthKeyList().
+/* Ported from 8185: IsInPreAuthKeyList().
* (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.)
* Added by Annie, 2006-05-07.
*
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 2095de72596a..3f6fb0543e1e 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -1975,3 +1975,4 @@ static int __init vme_init(void)
return bus_register(&vme_bus_type);
}
subsys_initcall(vme_init);
+
diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index 731fbba17dfd..7647dea15f75 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -1296,3 +1296,4 @@ MODULE_LICENSE("GPL");
module_init(fake_init);
module_exit(fake_exit);
+
diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
index 733594dde9ae..1c5389020924 100644
--- a/drivers/staging/vme_user/vme_tsi148.c
+++ b/drivers/staging/vme_user/vme_tsi148.c
@@ -2634,3 +2634,4 @@ module_param(geoid, uint, 0);
MODULE_DESCRIPTION("VME driver for the Tundra Tempe VME bridge");
MODULE_LICENSE("GPL");
+
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: fix various code style issues
2025-11-02 7:42 [PATCH] staging: fix various code style issues Chang Junzheng
@ 2025-11-02 11:32 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-11-02 11:32 UTC (permalink / raw)
To: Chang Junzheng; +Cc: linux-staging, linux-kernel
On Sun, Nov 02, 2025 at 03:42:15PM +0800, Chang Junzheng wrote:
> Fix trailing whitespace in rtl8723bs driver and add missing
> newlines at end of file in multiple staging drivers.
>
> Changes include:
> - Remove trailing whitespace from rtl8723bs/core/rtw_mlme.c
> - Add missing newline at EOF for vme_user/vme.c
> - Add missing newline at EOF for vme_user/vme_fake.c
> - Add missing newline at EOF for vme_user/vme_tsi148.c
>
> This addresses checkpatch.pl warnings about code style compliance.
>
> Signed-off-by: Chang Junzheng <guagua210311@qq.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> drivers/staging/vme_user/vme.c | 1 +
> drivers/staging/vme_user/vme_fake.c | 1 +
> drivers/staging/vme_user/vme_tsi148.c | 1 +
> 4 files changed, 4 insertions(+), 1 deletion(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-02 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-02 7:42 [PATCH] staging: fix various code style issues Chang Junzheng
2025-11-02 11:32 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox