linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Dave Penkler <dpenkler@gmail.com>,
	gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, johan@kernel.org,
	Dave Penkler <dpenkler@gmail.com>
Subject: Re: [PATCH V3 6/6] gpib: Destage gpib
Date: Fri, 14 Nov 2025 14:46:03 +0800	[thread overview]
Message-ID: <202511141035.1unt5Lt7-lkp@intel.com> (raw)
In-Reply-To: <20251113104543.5875-7-dpenkler@gmail.com>

Hi Dave,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on staging/staging-next staging/staging-linus linus/master v6.18-rc5 next-20251113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dave-Penkler/staging-Remove-gpib-build-from-staging/20251113-185632
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20251113104543.5875-7-dpenkler%40gmail.com
patch subject: [PATCH V3 6/6] gpib: Destage gpib
config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20251114/202511141035.1unt5Lt7-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511141035.1unt5Lt7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511141035.1unt5Lt7-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpib/common/iblib.c:165:12: warning: 'autospoll_thread' defined but not used [-Wunused-function]
     165 | static int autospoll_thread(void *board_void)
         |            ^~~~~~~~~~~~~~~~


vim +/autospoll_thread +165 drivers/gpib/common/iblib.c

9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  164  
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18 @165  static int autospoll_thread(void *board_void)
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  166  {
840459da1574db drivers/staging/gpib/common/iblib.c Michael Rubin 2025-03-19  167  	struct gpib_board *board = board_void;
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  168  	int retval = 0;
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  169  
a836d4ec8f83bb drivers/staging/gpib/common/iblib.c Dave Penkler  2024-11-04  170  	dev_dbg(board->gpib_dev, "entering autospoll thread\n");
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  171  
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  172  	while (1) {
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  173  		wait_event_interruptible(board->wait,
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  174  					 kthread_should_stop() ||
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  175  					 autospoll_wait_should_wake_up(board));
a836d4ec8f83bb drivers/staging/gpib/common/iblib.c Dave Penkler  2024-11-04  176  		dev_dbg(board->gpib_dev, "autospoll wait satisfied\n");
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  177  		if (kthread_should_stop())
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  178  			break;
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  179  
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  180  		mutex_lock(&board->big_gpib_mutex);
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  181  		/* make sure we are still good after we have lock */
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  182  		if (board->autospollers <= 0 || board->master == 0) {
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  183  			mutex_unlock(&board->big_gpib_mutex);
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  184  			continue;
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  185  		}
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  186  		mutex_unlock(&board->big_gpib_mutex);
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  187  
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  188  		if (try_module_get(board->provider_module)) {
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  189  			retval = autopoll_all_devices(board);
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  190  			module_put(board->provider_module);
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  191  		} else {
141765729ea7c8 drivers/staging/gpib/common/iblib.c Dave Penkler  2025-02-14  192  			dev_err(board->gpib_dev, "try_module_get() failed!\n");
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  193  		}
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  194  		if (retval <= 0) {
141765729ea7c8 drivers/staging/gpib/common/iblib.c Dave Penkler  2025-02-14  195  			dev_err(board->gpib_dev, "stuck SRQ\n");
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  196  
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  197  			atomic_set(&board->stuck_srq, 1);	// XXX could be better
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  198  			set_bit(SRQI_NUM, &board->status);
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  199  		}
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  200  	}
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  201  	return retval;
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  202  }
9dde4559e93955 drivers/staging/gpib/common/iblib.c Dave Penkler  2024-09-18  203  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-11-14  6:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 10:45 [PATCH V3 0/6] Destage gpib drivers Dave Penkler
2025-11-13 10:45 ` [PATCH V3 1/6] staging: Remove gpib build from staging Dave Penkler
2025-11-13 10:45 ` [PATCH V3 2/6] staging: gpib: Remove gpib/uapi from search path Dave Penkler
2025-11-13 10:45 ` [PATCH V3 3/6] staging: gpib: Change file path for uapi headers Dave Penkler
2025-11-13 10:45 ` [PATCH V3 4/6] staging: gpib: Update TODO file Dave Penkler
2025-11-13 10:45 ` [PATCH V3 5/6] staging: gpib: Fix SPDX license for gpib headers Dave Penkler
2025-11-13 10:45 ` [PATCH V3 6/6] gpib: Destage gpib Dave Penkler
2025-11-14  6:45   ` kernel test robot
2025-11-14  6:46   ` kernel test robot [this message]
2025-11-14  6:47   ` kernel test robot
2025-11-14  8:49 ` [PATCH V3 0/6] Destage gpib drivers Johan Hovold
2025-11-14 10:21   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202511141035.1unt5Lt7-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).