From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: johan@kernel.org, Dave Penkler <dpenkler@gmail.com>
Subject: [PATCH V4 2/4] staging: gpib: Update TODO file
Date: Mon, 17 Nov 2025 15:40:19 +0100 [thread overview]
Message-ID: <20251117144021.23569-3-dpenkler@gmail.com> (raw)
In-Reply-To: <20251117144021.23569-1-dpenkler@gmail.com>
The comments have now been fixed so remove the item about
comments from the TODO file.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/staging/gpib/TODO | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/gpib/TODO b/drivers/staging/gpib/TODO
index ab41a7f9ca5b..ac07dd90b4ef 100644
--- a/drivers/staging/gpib/TODO
+++ b/drivers/staging/gpib/TODO
@@ -4,20 +4,6 @@ TODO:
CHECK:ALLOC_SIZEOF_STRUCT: Prefer kmalloc(sizeof(*board->private_data)...) over kmalloc(sizeof(struct xxx_priv)...)
./gpio/gpib_bitbang.c:50: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parenthese
This warning will be addressed later: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string
-- tidy-up comments:
- - there are some "//comments" and "// comments" scattered around
- - sometimes they are misaligned
- - sometimes "// comments" are interleaved with "/* comments */"
- - multiline comments should start with initial almost-blank line:
- /*
- * Good
- * multiline
- * comment
- */
- /* Bad
- * multiline
- * comment
- */
- resolve XXX notes where possible
- fix FIXME notes
- clean-up commented-out code
--
2.51.2
next prev parent reply other threads:[~2025-11-17 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 14:40 [PATCH V4 0/4] Destage gpib drivers Dave Penkler
2025-11-17 14:40 ` [PATCH V4 1/4] staging: gpib: Change // comments in uapi header file Dave Penkler
2025-11-17 14:40 ` Dave Penkler [this message]
2025-11-17 14:40 ` [PATCH V4 3/4] staging: gpib: Fix SPDX license for gpib headers Dave Penkler
2025-11-17 14:40 ` [PATCH V4 4/4] gpib: Destage gpib Dave Penkler
2025-11-24 16:42 ` Greg KH
2025-11-24 16:53 ` [PATCH V4 0/4] Destage gpib drivers Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117144021.23569-3-dpenkler@gmail.com \
--to=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).