Re: [PATCH 4/5] staging: rtl8723bs: remove dead code from odm.c

Dan Carpenter
2025-11-24T08:11:21Z

On Sat, Nov 22, 2025 at 05:45:54PM +0000, Navaneeth K wrote:
> Remove commented-out code references to RTL8723A and RTL8188E which
> are not supported by this driver. This cleans up the source file and
> improves readability.
>
> Signed-off-by: Navaneeth K <knavaneeth786@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/odm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
> index 4b36af47f680..08ed38b2a563 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.c
> +++ b/drivers/staging/rtl8723bs/hal/odm.c
> @@ -610,10 +610,6 @@ void ODM_DMWatchdog(struct dm_odm_t *pDM_Odm)
> /* NeilChen--2012--08--24-- */
> /* Fix Leave LPS issue */
> if ((adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode != PS_MODE_ACTIVE) /* in LPS mode */
> - /* */
> - /* (pDM_Odm->SupportICType & (ODM_RTL8723A))|| */
> - /* (pDM_Odm->SupportICType & (ODM_RTL8188E) &&(&&(((pDM_Odm->SupportInterface == ODM_ITRF_SDIO))) */
> - /* */
> ) {

When you're breaking things up into One Thing Per Patch, these bits
were part of the condition so it's allowed to move the ") {" to the
earlier line. It's part of fixing the condition.

regards,
dan carpenter

> odm_DIGbyRSSI_LPS(pDM_Odm);
> } else
> --
> 2.43.0
>