[PATCH] staging: most: video: replace BUG_ON() with WARN_ON_ONCE()

[PATCH] staging: most: video: replace BUG_ON() with WARN_ON_ONCE()

[Pavan Kumar Yalagada]

checkpatch.pl recommends replacing BUG_ON() with WARN_ON_ONCE()
to avoid a kernel panic.

Signed-off-by: Pavan Kumar Yalagada <pavankumaryalagada@gmail.com>
---
 drivers/staging/most/video/video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
index 32f71d9a9cf7..3a622bd597e6 100644
--- a/drivers/staging/most/video/video.c
+++ b/drivers/staging/most/video/video.c
@@ -575,7 +575,7 @@ static void __exit comp_exit(void)
 
 	most_deregister_configfs_subsys(&comp);
 	most_deregister_component(&comp);
-	BUG_ON(!list_empty(&video_devices));
+	WARN_ON_ONCE(!list_empty(&video_devices));
 }
 
 module_init(comp_init);
-- 
2.47.3

Re: [PATCH] staging: most: video: replace BUG_ON() with WARN_ON_ONCE()

[Greg KH]

On Fri, Nov 21, 2025 at 02:09:09PM -0500, Pavan Kumar Yalagada wrote:
> checkpatch.pl recommends replacing BUG_ON() with WARN_ON_ONCE()
> to avoid a kernel panic.
> 
> Signed-off-by: Pavan Kumar Yalagada <pavankumaryalagada@gmail.com>
> ---
>  drivers/staging/most/video/video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index 32f71d9a9cf7..3a622bd597e6 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -575,7 +575,7 @@ static void __exit comp_exit(void)
>  
>  	most_deregister_configfs_subsys(&comp);
>  	most_deregister_component(&comp);
> -	BUG_ON(!list_empty(&video_devices));
> +	WARN_ON_ONCE(!list_empty(&video_devices));

But this doesn't handle the fact that the system is now unstable.
Please fix the root cause of this, do not paper over the problem.

thanks,

greg k-h

Re: [PATCH] staging: most: video: replace BUG_ON() with WARN_ON_ONCE()

[Dan Carpenter]

On Fri, Nov 21, 2025 at 02:09:09PM -0500, Pavan Kumar Yalagada wrote:
> checkpatch.pl recommends replacing BUG_ON() with WARN_ON_ONCE()
> to avoid a kernel panic.
> 
> Signed-off-by: Pavan Kumar Yalagada <pavankumaryalagada@gmail.com>
> ---
>  drivers/staging/most/video/video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index 32f71d9a9cf7..3a622bd597e6 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -575,7 +575,7 @@ static void __exit comp_exit(void)
>  
>  	most_deregister_configfs_subsys(&comp);
>  	most_deregister_component(&comp);
> -	BUG_ON(!list_empty(&video_devices));
> +	WARN_ON_ONCE(!list_empty(&video_devices));

The start of the function empties the list.  So the list would only
not be empty if something were adding new entries to it via the
comp_probe_channel() function.

So what is preventing us from adding new stuff once comp_exit()
starts being called?  Figure that bit out.  Fix the bug, don't
add a warning about the bug.

regards,
dan carpenter