From: Greg KH <gregkh@linuxfoundation.org>
To: Adam Quandour <adam.quandour@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
niharchaithanya@gmail.com, dan.carpenter@linaro.org,
matchstick@neverthere.org, dpenkler@gmail.com
Subject: Re: [PATCH] staging: gpib: Clean-up commented-out code
Date: Mon, 24 Nov 2025 17:54:23 +0100 [thread overview]
Message-ID: <2025112415-suitcase-console-5b2d@gregkh> (raw)
In-Reply-To: <20251117092020.8473-1-adam.quandour@gmail.com>
On Mon, Nov 17, 2025 at 12:20:20PM +0300, Adam Quandour wrote:
> Remove unused code.
>
> Signed-off-by: Adam Quandour <adam.quandour@gmail.com>
> ---
> drivers/staging/gpib/cb7210/cb7210.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
> index 3e2397898a9b..24c61b151071 100644
> --- a/drivers/staging/gpib/cb7210/cb7210.c
> +++ b/drivers/staging/gpib/cb7210/cb7210.c
> @@ -1290,26 +1290,14 @@ static void cb_gpib_release(struct pcmcia_device *link)
>
> static int cb_gpib_suspend(struct pcmcia_device *link)
> {
> - //struct local_info *info = link->priv;
> - //struct struct gpib_board *dev = info->dev;
> -
> if (link->open)
> dev_warn(&link->dev, "Device still open\n");
> - //netif_device_detach(dev);
>
> return 0;
> }
>
> static int cb_gpib_resume(struct pcmcia_device *link)
> {
> - //struct local_info *info = link->priv;
> - //struct struct gpib_board *dev = info->dev;
> -
> - /*if (link->open) {
> - * ni_gpib_probe(dev); / really?
> - * //netif_device_attach(dev);
> - *
> - */
> return cb_gpib_config(link);
> }
>
> --
> 2.51.0
>
The code has now moved directories :(
next prev parent reply other threads:[~2025-11-24 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:20 [PATCH] staging: gpib: Clean-up commented-out code Adam Quandour
2025-11-24 16:54 ` Greg KH [this message]
2025-11-24 17:00 ` Adam
2025-11-24 17:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025112415-suitcase-console-5b2d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adam.quandour@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matchstick@neverthere.org \
--cc=niharchaithanya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).