* [PATCH] staging: gpib: Clean-up commented-out code
@ 2025-11-17 9:20 Adam Quandour
2025-11-24 16:54 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Adam Quandour @ 2025-11-17 9:20 UTC (permalink / raw)
To: linux-staging
Cc: linux-kernel, niharchaithanya, dan.carpenter, matchstick, gregkh,
dpenkler, adam.quandour
Remove unused code.
Signed-off-by: Adam Quandour <adam.quandour@gmail.com>
---
drivers/staging/gpib/cb7210/cb7210.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
index 3e2397898a9b..24c61b151071 100644
--- a/drivers/staging/gpib/cb7210/cb7210.c
+++ b/drivers/staging/gpib/cb7210/cb7210.c
@@ -1290,26 +1290,14 @@ static void cb_gpib_release(struct pcmcia_device *link)
static int cb_gpib_suspend(struct pcmcia_device *link)
{
- //struct local_info *info = link->priv;
- //struct struct gpib_board *dev = info->dev;
-
if (link->open)
dev_warn(&link->dev, "Device still open\n");
- //netif_device_detach(dev);
return 0;
}
static int cb_gpib_resume(struct pcmcia_device *link)
{
- //struct local_info *info = link->priv;
- //struct struct gpib_board *dev = info->dev;
-
- /*if (link->open) {
- * ni_gpib_probe(dev); / really?
- * //netif_device_attach(dev);
- *
- */
return cb_gpib_config(link);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: gpib: Clean-up commented-out code
2025-11-17 9:20 [PATCH] staging: gpib: Clean-up commented-out code Adam Quandour
@ 2025-11-24 16:54 ` Greg KH
2025-11-24 17:00 ` Adam
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2025-11-24 16:54 UTC (permalink / raw)
To: Adam Quandour
Cc: linux-staging, linux-kernel, niharchaithanya, dan.carpenter,
matchstick, dpenkler
On Mon, Nov 17, 2025 at 12:20:20PM +0300, Adam Quandour wrote:
> Remove unused code.
>
> Signed-off-by: Adam Quandour <adam.quandour@gmail.com>
> ---
> drivers/staging/gpib/cb7210/cb7210.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
> index 3e2397898a9b..24c61b151071 100644
> --- a/drivers/staging/gpib/cb7210/cb7210.c
> +++ b/drivers/staging/gpib/cb7210/cb7210.c
> @@ -1290,26 +1290,14 @@ static void cb_gpib_release(struct pcmcia_device *link)
>
> static int cb_gpib_suspend(struct pcmcia_device *link)
> {
> - //struct local_info *info = link->priv;
> - //struct struct gpib_board *dev = info->dev;
> -
> if (link->open)
> dev_warn(&link->dev, "Device still open\n");
> - //netif_device_detach(dev);
>
> return 0;
> }
>
> static int cb_gpib_resume(struct pcmcia_device *link)
> {
> - //struct local_info *info = link->priv;
> - //struct struct gpib_board *dev = info->dev;
> -
> - /*if (link->open) {
> - * ni_gpib_probe(dev); / really?
> - * //netif_device_attach(dev);
> - *
> - */
> return cb_gpib_config(link);
> }
>
> --
> 2.51.0
>
The code has now moved directories :(
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: gpib: Clean-up commented-out code
2025-11-24 16:54 ` Greg KH
@ 2025-11-24 17:00 ` Adam
2025-11-24 17:07 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Adam @ 2025-11-24 17:00 UTC (permalink / raw)
To: Greg KH
Cc: linux-staging, linux-kernel, niharchaithanya, dan.carpenter,
matchstick, dpenkler
Oh, I will make a new patch then. It is in the same place in the
master branch. I should make the patch from another branch, right?
On Mon, Nov 24, 2025 at 7:54 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Nov 17, 2025 at 12:20:20PM +0300, Adam Quandour wrote:
> > Remove unused code.
> >
> > Signed-off-by: Adam Quandour <adam.quandour@gmail.com>
> > ---
> > drivers/staging/gpib/cb7210/cb7210.c | 12 ------------
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
> > index 3e2397898a9b..24c61b151071 100644
> > --- a/drivers/staging/gpib/cb7210/cb7210.c
> > +++ b/drivers/staging/gpib/cb7210/cb7210.c
> > @@ -1290,26 +1290,14 @@ static void cb_gpib_release(struct pcmcia_device *link)
> >
> > static int cb_gpib_suspend(struct pcmcia_device *link)
> > {
> > - //struct local_info *info = link->priv;
> > - //struct struct gpib_board *dev = info->dev;
> > -
> > if (link->open)
> > dev_warn(&link->dev, "Device still open\n");
> > - //netif_device_detach(dev);
> >
> > return 0;
> > }
> >
> > static int cb_gpib_resume(struct pcmcia_device *link)
> > {
> > - //struct local_info *info = link->priv;
> > - //struct struct gpib_board *dev = info->dev;
> > -
> > - /*if (link->open) {
> > - * ni_gpib_probe(dev); / really?
> > - * //netif_device_attach(dev);
> > - *
> > - */
> > return cb_gpib_config(link);
> > }
> >
> > --
> > 2.51.0
> >
>
> The code has now moved directories :(
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: gpib: Clean-up commented-out code
2025-11-24 17:00 ` Adam
@ 2025-11-24 17:07 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2025-11-24 17:07 UTC (permalink / raw)
To: Adam
Cc: linux-staging, linux-kernel, niharchaithanya, dan.carpenter,
matchstick, dpenkler
On Mon, Nov 24, 2025 at 08:00:20PM +0300, Adam wrote:
> Oh, I will make a new patch then. It is in the same place in the
> master branch. I should make the patch from another branch, right?
Look at the staging-testing branch now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-24 17:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-17 9:20 [PATCH] staging: gpib: Clean-up commented-out code Adam Quandour
2025-11-24 16:54 ` Greg KH
2025-11-24 17:00 ` Adam
2025-11-24 17:07 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).