From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bryant Boatright <bryant.boatright@proton.me>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: Re: [PATCH v2 1/3] staging: rtl8723bs: Rename camel case enumeration
Date: Mon, 24 Nov 2025 17:45:40 +0100 [thread overview]
Message-ID: <2025112434-outbid-tidbit-3192@gregkh> (raw)
In-Reply-To: <37abbb9fb3c082e587f1c22321f57287d0c7e660.1762803720.git.bryant.boatright@proton.me>
On Mon, Nov 10, 2025 at 07:49:16PM +0000, Bryant Boatright wrote:
> Adhere to Linux kernel style.
>
> Reported by checkpatch:
>
> CHECK: Avoid CamelCase: <ParseRes>
> CHECK: Avoid CamelCase: <ParseFailed>
> CHECK: Avoid CamelCase: <ParseUnknown>
> CHECK: Avoid CamelCase: <ParseOK>
If you are changing the name, let's pick something that makes sense:
> -enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
> +enum parse_res { PARSE_OK = 0, PARSE_UNKNOWN = 1, PARSE_FAILED = -1 };
These should be on multiple lines too, right?
Anway, "parse_res" doesn't make much sense, how about "parse_state"?
"parse_result"? Something else?
naming is hard :)
thanks,
greg k-h
next prev parent reply other threads:[~2025-11-24 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 19:48 [PATCH v2 0/3] Checkpatch cleanup patches Bryant Boatright
2025-11-10 19:49 ` [PATCH v2 1/3] staging: rtl8723bs: Rename camel case enumeration Bryant Boatright
2025-11-24 16:45 ` Greg Kroah-Hartman [this message]
2025-11-10 19:49 ` [PATCH v2 2/3] staging: rtl8723bs: Rename camel case argument Bryant Boatright
2025-11-24 16:44 ` Greg Kroah-Hartman
2025-11-10 19:50 ` [PATCH v2 3/3] staging: rtl8723bs: Rename camel case variiable Bryant Boatright
2025-11-24 16:45 ` Greg Kroah-Hartman
2025-11-24 16:46 ` [PATCH v2 0/3] Checkpatch cleanup patches Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025112434-outbid-tidbit-3192@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bryant.boatright@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox