From: Navaneeth K <knavaneeth786@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
dan.carpenter@linaro.org, david.laight@runbox.com,
Navaneeth K <knavaneeth786@gmail.com>
Subject: [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup
Date: Tue, 25 Nov 2025 11:20:54 +0000 [thread overview]
Message-ID: <20251125112059.16913-1-knavaneeth786@gmail.com> (raw)
This series cleans up the rtl8723bs driver by removing the custom
FIELD_OFFSET macro and replacing its usages with the standard offsetof()
from <linux/stddef.h>.
Changes in v2:
- Split the series for proper bisectability: the FIELD_OFFSET macro
definition is now removed in Patch 5 (after all usages are converted),
rather than in Patch 1.
- Patch 1: Now only removes unused RGTRY_OFT, RGTRY_SZ, BSSID_OFT, and
BSSID_SZ macros (dead code not used anywhere in the driver).
- Patch 2: Split long line to fit within 100 columns. Also added
<linux/stddef.h> include to basic_types.h to support offsetof usage.
- Patch 3: Fixed brace formatting issue caused by removing commented
code. Removed unnecessary outer parentheses, moved the inline
comment to its own line, and added braces to the else branch for
consistent style.
- Patch 5 (NEW): Remove FIELD_OFFSET definition now that it's unused.
Navaneeth K (5):
staging: rtl8723bs: remove unused registry and BSSID offset macros
staging: rtl8723bs: use standard offsetof in cfg80211 operations
staging: rtl8723bs: remove dead commented code from odm.c
staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof in
rtw_mlme_ext.c
staging: rtl8723bs: remove custom FIELD_OFFSET macro
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
drivers/staging/rtl8723bs/hal/odm.c | 13 +++++--------
drivers/staging/rtl8723bs/include/basic_types.h | 3 +--
drivers/staging/rtl8723bs/include/drv_types.h | 7 -------
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++-
5 files changed, 10 insertions(+), 20 deletions(-)
--
2.43.0
next reply other threads:[~2025-11-25 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 11:20 Navaneeth K [this message]
2025-11-25 11:20 ` [PATCH v2 1/5] staging: rtl8723bs: remove unused registry and BSSID offset macros Navaneeth K
2025-11-25 11:20 ` [PATCH v2 2/5] staging: rtl8723bs: use standard offsetof in cfg80211 operations Navaneeth K
2025-11-25 11:20 ` [PATCH v2 3/5] staging: rtl8723bs: remove dead commented code from odm.c Navaneeth K
2025-11-25 11:20 ` [PATCH v2 4/5] staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof in rtw_mlme_ext.c Navaneeth K
2025-11-25 11:20 ` [PATCH v2 5/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro Navaneeth K
2025-11-25 12:10 ` [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125112059.16913-1-knavaneeth786@gmail.com \
--to=knavaneeth786@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=david.laight@runbox.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).