From: Navaneeth K <knavaneeth786@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
dan.carpenter@linaro.org, david.laight@runbox.com,
Navaneeth K <knavaneeth786@gmail.com>
Subject: [PATCH v2 3/5] staging: rtl8723bs: remove dead commented code from odm.c
Date: Tue, 25 Nov 2025 11:20:57 +0000 [thread overview]
Message-ID: <20251125112059.16913-4-knavaneeth786@gmail.com> (raw)
In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com>
Remove obsolete commented-out code that references unsupported chip
variants (ODM_RTL8723A, ODM_RTL8188E). This code has been dead since
the driver was added to staging.
Also fix the resulting formatting by removing the unnecessary outer
parentheses and moving the inline comment to its own line.
Signed-off-by: Navaneeth K <knavaneeth786@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
index 4b36af47f680..639b6da2302b 100644
--- a/drivers/staging/rtl8723bs/hal/odm.c
+++ b/drivers/staging/rtl8723bs/hal/odm.c
@@ -609,15 +609,12 @@ void ODM_DMWatchdog(struct dm_odm_t *pDM_Odm)
/* 8723A or 8189ES platform */
/* NeilChen--2012--08--24-- */
/* Fix Leave LPS issue */
- if ((adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode != PS_MODE_ACTIVE) /* in LPS mode */
- /* */
- /* (pDM_Odm->SupportICType & (ODM_RTL8723A))|| */
- /* (pDM_Odm->SupportICType & (ODM_RTL8188E) &&(&&(((pDM_Odm->SupportInterface == ODM_ITRF_SDIO))) */
- /* */
- ) {
- odm_DIGbyRSSI_LPS(pDM_Odm);
- } else
+ if (adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode != PS_MODE_ACTIVE) {
+ /* in LPS mode */
+ odm_DIGbyRSSI_LPS(pDM_Odm);
+ } else {
odm_DIG(pDM_Odm);
+ }
{
struct dig_t *pDM_DigTable = &pDM_Odm->DM_DigTable;
--
2.43.0
next prev parent reply other threads:[~2025-11-25 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 11:20 [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup Navaneeth K
2025-11-25 11:20 ` [PATCH v2 1/5] staging: rtl8723bs: remove unused registry and BSSID offset macros Navaneeth K
2025-11-25 11:20 ` [PATCH v2 2/5] staging: rtl8723bs: use standard offsetof in cfg80211 operations Navaneeth K
2025-11-25 11:20 ` Navaneeth K [this message]
2025-11-25 11:20 ` [PATCH v2 4/5] staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof in rtw_mlme_ext.c Navaneeth K
2025-11-25 11:20 ` [PATCH v2 5/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro Navaneeth K
2025-11-25 12:10 ` [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125112059.16913-4-knavaneeth786@gmail.com \
--to=knavaneeth786@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=david.laight@runbox.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).